Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#320 broke IDL: MediaSessionActionHandler can only use the base MediaSessionActionDetails but not any extensions #322

Closed
saschanaz opened this issue Mar 10, 2024 · 1 comment
Labels

Comments

@saschanaz
Copy link
Member

saschanaz commented Mar 10, 2024

The handler is defined in https://w3c.github.io/mediasession/#the-mediasession-interface as:

callback MediaSessionActionHandler = undefined(MediaSessionActionDetails details);

Since MediaSessionActionDetails is a dictionary, it can only expose any members that only MediaSessionActionDetails have, per the dictionary conversion steps. (One might expect that it would allow exposing subdictionaries, but it doesn't work that way.)

I don't think it would be worth (if even possible) complicating the types further with extra handler types, so my recommendation would be to roll it back and add the new member in the existing Details dictionary.

cc @youennf

@youennf
Copy link
Contributor

youennf commented Oct 4, 2024

Fixed in 51e3cd5

@youennf youennf closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants