From 94f6dd48b9da09ae70f65f3ab5d1c6186066d085 Mon Sep 17 00:00:00 2001 From: Scott O'Hara Date: Wed, 2 Nov 2022 12:51:47 -0400 Subject: [PATCH 1/7] revise allowed attributes on summary element Normative follow-on from #434 The spec was updated to note that the summary element doesnt' always map to the button element. The allowed attributes indicated that all attributes that were applicable to the button role were allowed. However, in practice this doesn't make sense and could break or be in contradiction to the implicit semantics. The allowed aria-* attributes for the button role include * aria-disabled * aria-haspopup * aria-expanded * aria-pressed Of those four, aria-expanded and pressed are the ones that would pose problems by conflicting or not making any sense with the implicit expanded/collapsed states provided by the element (who gets the state per the parent details having an open attribute or not). --- index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/index.html b/index.html index 4a32836..c1062d4 100644 --- a/index.html +++ b/index.html @@ -2788,8 +2788,8 @@

No `role`

- Global `aria-*` attributes - and any `aria-*` attributes applicable to the `button` role. + Global `aria-*` attributes, + `aria-disabled`, and `aria-haspopup` attributes.

From 366423087af9a648b2de1267f98769db41d9e397 Mon Sep 17 00:00:00 2001 From: Scott O'Hara Date: Tue, 7 Feb 2023 10:09:23 -0500 Subject: [PATCH 2/7] revise placement of proposed/addition classes move to the parent paragraph element, rather than being on a child span. --- index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/index.html b/index.html index 1943533..c1944ff 100644 --- a/index.html +++ b/index.html @@ -2887,9 +2887,9 @@

No `role`

-

+

Global `aria-*` attributes, - `aria-disabled`, and `aria-haspopup` attributes. + `aria-disabled`, and `aria-haspopup` attributes.

From 253a5b262e4e007c2f0442696af2ea6d48fdc935 Mon Sep 17 00:00:00 2001 From: Scott O'Hara Date: Tue, 7 Feb 2023 10:29:29 -0500 Subject: [PATCH 3/7] further clarifications for summary element allowances this addition to the PR takes into account that only a summary element that serves as the 'summary for its parent details' needs to adhere to these rules. otherwise, a summary element that doesn't meet the criteria of the HTML spec is essentially just a generic element, so any roles/attributes can be used on that. --- index.html | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/index.html b/index.html index c1944ff..6608193 100644 --- a/index.html +++ b/index.html @@ -2884,13 +2884,21 @@

-

- No `role` -

-

- Global `aria-*` attributes, - `aria-disabled`, and `aria-haspopup` attributes. -

+
+

+ No `role` if the `summary` element is a + summary for its parent details. +

+

+ Global `aria-*` attributes, + `aria-disabled`, and `aria-haspopup` attributes. +

+

+ Otherwise, authors MAY specifiy Any `role`, and any + global `aria-*` attributes + and any `aria-*` attributes applicable to the allowed roles. +

+
From c6d34ef5b32430df3ab35da0eab94a112de8632f Mon Sep 17 00:00:00 2001 From: Scott O'Hara Date: Mon, 13 Feb 2023 10:27:08 -0500 Subject: [PATCH 4/7] remove extra instances of update classes removed extra instance of nested "proposed correction" classes within an element that already had these classes --- index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/index.html b/index.html index 35e12ba..20187a0 100644 --- a/index.html +++ b/index.html @@ -2879,7 +2879,7 @@

- + [^summary^] @@ -2897,7 +2897,7 @@

No `role` if the `summary` element is a summary for its parent details.

-

+

Global `aria-*` attributes, `aria-disabled`, and `aria-haspopup` attributes.

From f3197abbfdc515daa3547dbb21ddf7caf5f79a84 Mon Sep 17 00:00:00 2001 From: Scott O'Hara Date: Mon, 13 Feb 2023 10:27:43 -0500 Subject: [PATCH 5/7] fix typo --- index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.html b/index.html index 20187a0..9b01969 100644 --- a/index.html +++ b/index.html @@ -2879,7 +2879,7 @@

- + [^summary^] From 9f80e5648b99c30158ceb8ffdb9ee2bbd86a114a Mon Sep 17 00:00:00 2001 From: Scott O'Hara Date: Mon, 13 Feb 2023 11:12:02 -0500 Subject: [PATCH 6/7] remove extra use of the word 'role' --- index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/index.html b/index.html index 9b01969..eae6a92 100644 --- a/index.html +++ b/index.html @@ -2887,8 +2887,8 @@

No corresponding role

- Many, but not all, user agents expose the `summary` element with an implicit ARIA role=button - role. + Many, but not all, user agents expose the `summary` element with an implicit ARIA + role=button.
From f0a0495cd2f0e5d172eb1f5576b477dcbca45ced Mon Sep 17 00:00:00 2001 From: Scott O'Hara Date: Wed, 31 May 2023 10:30:45 -0400 Subject: [PATCH 7/7] update changelog --- index.html | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/index.html b/index.html index 4c18553..0c2e636 100644 --- a/index.html +++ b/index.html @@ -63,6 +63,10 @@ the following substantive additions and/or corrections have been proposed: