Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document type declarations for ONIX? #1373

Closed
murata2makoto opened this issue Oct 27, 2020 · 3 comments
Closed

Document type declarations for ONIX? #1373

murata2makoto opened this issue Oct 27, 2020 · 3 comments
Labels
EPUB33 Issues addressed in the EPUB 3.3 revision Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation

Comments

@murata2makoto
Copy link
Contributor

murata2makoto commented Oct 27, 2020

EDItEUR does not recommend the use of DTD for ONIX 3.0. Moreover, no public identifiers or system identifiers are provided. EDItEUR provides more information about valdiation.

I thus think that we should not allow document type declarations for ONIX. Do people agree?

This issue is to create § B. Allowed External Identifiers as proposed in #1368.

@murata2makoto
Copy link
Contributor Author

murata2makoto commented Oct 27, 2020

The DTD for ONIX 2.0 was available at https://www.editeur.org/onix/2.1/02/reference/onix-international.dtd, but it is no there anymore. See Using local DTD and XSD files after ONIX 2.1 sunset.

@mattgarrish
Copy link
Member

This seems to be generally true for metadata records. MODS, MARCXML and XMP also don't have DTDs.

@mattgarrish mattgarrish added Topic-ContentDocs The issue affects EPUB content documents Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation and removed Topic-ContentDocs The issue affects EPUB content documents labels Oct 30, 2020
@iherman
Copy link
Member

iherman commented Nov 6, 2020

This issue was discussed in a meeting.

  • RESOLVED: Merge PR #1368 to address outstanding DTD issues, and close GH issues 1369-1373
View the transcript Wendy Reid: we had resolutions at the F2F, and further discussions on github
… and came to a happy place
Matt Garrish: #1368
Matt Garrish: where we ended up was…
… we put in an allowance for a specific set of external identifiers that we have put in an appendix
… we have SVG and MathML that are allowed to be used in content docs or in separate files
… and we made a restriction against external entities in the internal DTD subset
… so it prevents some security issues but eases authoring
… so we’ll no longer force people to remove SVG DTDs from tool-generated files
… I’m hoping this is it :)
Ivan Herman: tech comment
… in fact, the changes are such that
… makes possible something that I’m not sure we really use
… I can define as part of an internal entity something that won’t go out to the network
… I’m not sure if this feature is in use
… formal comment
… there was a formal resolution on the previous version; this PR slightly changes that
… can we get a formal resolution to merge, and also close a bunch of issues which were examples of the problem?
Proposed resolution: Merge PR #1368 to address outstanding DTD issues, and close GH issues 1369-1373 (Wendy Reid)
Garth Conboy: +1
Matt Garrish: +1
Ivan Herman: +1
Charles LaPierre: +1
Matthew Chan: +1
Wendy Reid: +1
Brady Duga: +1
George Kerscher: +1
Laura Brady: +1
Bill Kasdorf: +1
Ben Schroeter: +1
Resolution #1: Merge PR #1368 to address outstanding DTD issues, and close GH issues 1369-1373

@iherman iherman closed this as completed Nov 6, 2020
@mattgarrish mattgarrish added EPUB33 Issues addressed in the EPUB 3.3 revision and removed EPUB33 Issues addressed in the EPUB 3.3 revision labels Nov 9, 2020
@mattgarrish mattgarrish added the EPUB33 Issues addressed in the EPUB 3.3 revision label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPUB33 Issues addressed in the EPUB 3.3 revision Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation
Projects
None yet
Development

No branches or pull requests

3 participants