Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "created" and "updated" from Core Properties to DID document metadata #365

Merged
merged 4 commits into from
Aug 11, 2020
Merged

Move "created" and "updated" from Core Properties to DID document metadata #365

merged 4 commits into from
Aug 11, 2020

Conversation

peacekeeper
Copy link
Contributor

@peacekeeper peacekeeper commented Jul 30, 2020 •
edited by pr-preview bot
Loading

Addresses #203 and #174.

Preview | Diff

@peacekeeper peacekeeper mentioned this pull request Jul 30, 2020
Closed
@peacekeeper peacekeeper force-pushed the peacekeeper-created-updated-metadata branch from bb2189d to 6ae6c65 Compare July 31, 2020 12:50
@rhiaro rhiaro mentioned this pull request Aug 2, 2020
Merged
msporny
msporny requested changes Aug 10, 2020
View reviewed changes
Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, otherwise LGTM.

index.html Outdated Show resolved Hide resolved
index.html Outdated

<pre class="example" title="JSON-encoded DID document metadata example">
{
"created": "2002-10-10T17:00:00Z",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should use a date that is within the range of when the DID spec existed. So, perhaps using created dates after 2018 and update dates after 2020 would be more realistic? :)

Copy link
Contributor Author

@peacekeeper peacekeeper Aug 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the example dates in 6663b38.

@msporny
Copy link
Member

msporny commented Aug 10, 2020

Merge conflicts need to be resolved.

@peacekeeper peacekeeper force-pushed the peacekeeper-created-updated-metadata branch from 2609723 to 6663b38 Compare August 10, 2020 13:59
@peacekeeper
Copy link
Contributor Author

@msporny thanks, merge conflicts should be fixed now.

OR13
OR13 approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

selfissued
selfissued approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of moving these properties to the metadata. However, this PR does not address issue #174 - as it does not specify the semantics of these values.

@peacekeeper
Copy link
Contributor Author

However, this PR does not address issue #174 - as it does not specify the semantics of these values.

Thanks @selfissued, the PR says the following:

DID document metadata SHOULD include an updated property to indicate the timestamp of the last Update operation.

I think "timestamp of the last Update operation" should be sufficient as a definition. My idea is that if additional explanations are needed, then those should be added to the section about the Update operation, not to the metadata property.

@msporny
Copy link
Member

msporny commented Aug 11, 2020

Mostly editorial, multiple positive reviews, changes requested and made, merging.

@msporny msporny merged commit 4dedfe5 into master Aug 11, 2020
@peacekeeper peacekeeper mentioned this pull request Aug 25, 2020
Closed
peacekeeper added a commit to peacekeeper/did-core that referenced this pull request Aug 26, 2020
@peacekeeper
Remove "created" and "updated" from Core Properties reference list.
28510b6 
Those properties were moved from core properties to metadata in w3c#365.
peacekeeper added a commit to peacekeeper/did-core that referenced this pull request Aug 26, 2020
@peacekeeper
Remove "created" and "updated" from Core Properties reference list.
8c47db8 
Those properties were moved from core properties to DID document metadata in w3c#365.
@peacekeeper peacekeeper mentioned this pull request Aug 26, 2020
Closed
@msporny msporny deleted the peacekeeper-created-updated-metadata branch November 8, 2020 17:17
msporny pushed a commit to w3c/cid that referenced this pull request Jun 2, 2024
@peacekeeper
Remove "created" and "updated" from Core Properties reference list.
fbaf1b5 
Those properties were moved from core properties to DID document metadata in w3c/did-core#365.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdenhartog kdenhartog kdenhartog approved these changes

@brentzundel brentzundel brentzundel approved these changes

@OR13 OR13 OR13 approved these changes

@selfissued selfissued selfissued approved these changes

@dlongley dlongley dlongley approved these changes

@msporny msporny msporny approved these changes

@jricher jricher Awaiting requested review from jricher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@peacekeeper @msporny @dlongley @selfissued @OR13 @brentzundel @kdenhartog