-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does compute pressure reflect OS-level speed limit changes due to throttling? #228
Comments
@brycepj, thanks for sharing your use case and questions. I'm hearing that you'd prefer a catch-all source that considers global thermal and power constraints? Would such a catch-all source be adequate or would your use cases in addition require processing unit-level insight? We evolve this API based real-world use cases such as yours. Feel free to watch this repo and take part in related design discussions as they emerge. Thank you for your contributions. I'll label this as "v2" to give it better visibility in our issue triage. |
Thanks for your thoughtful response 🙇 Yes, I do think a catch-all source would be valuable. The primary uses we have at Slack for this feature are:
|
We recently added "thermals" as a source as well that it intended to reflect whether the system is being throttled or not. We did need to find the best way to implement this on different systems, as it is not always straight forward. |
@anssiko @kenchris Thanks for the responses. We're very excited about developments here and eager to help however we can. For what it's worth, we're already experimenting with these APIs internally and will be expanding to Slack's customers in the coming weeks. If there's any information or data I can provide about our experience that would help you all, please do let me know. |
@brycepj, thank you. The intent of the Origin Trial is exactly to collect real-world feedback from users of the API. Please keep sharing your suggestions, feedback and questions in this issue, or open new issues as appropriate. I've scheduled time to discuss your feedback with the entire Working Group at our next f2f meeting that takes place mid-September. |
@brycepj We are very happy that you are playing around with the API and giving up this feedback. We would like to know if we could mention this publicly, say on presentation slides, possible together with your company logo? |
The Compute Pressure API was released on Chromium M125. Did you try it with Slack? Do you have any experience to share with us? |
Yes, we do observe compute pressure during Huddles with this API and have since M125. We don't currently use compute pressure levels to dynamically adapt quality, but do use it in internal reporting around performance/quality and as a diagnostic for reports about poor quality or performance. In general, I have found it quite useful/reliable for these things. We haven't yet used the 'thermals' source, mainly because we already use a comparable event emitted by Electron to detect thermal states. But I think it would be preferable to be using a Chromium API for this, so I'll definitely experiment with it and see how that goes. |
I work on video conferencing software that is embedded within a much larger, CPU-intensive application. We frequently deal with performance and quality issues that can be traced back to speed-limit changes triggered by thermal throttling or power management.
Since the PressureObserver API currently only supports the 'cpu' source, my question is whether compute pressure is calculated in a way that would reflect these throttling effects. In other words, if the operating system adjusts speed limits due to thermal or power constraints, would these changes be reflected in the compute pressure?
While I'm excited for the prospect of using other pressure sources in the future, I'm interested to understand if the compute pressure metric effectively serves as a catch-all, inclusive of the impacts from OS-level changes. I would appreciate any insights or clarifications.
The text was updated successfully, but these errors were encountered: