Editorial: Make specURLs consistent and fix some respec warnings #2305
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Looks good to me except for one minor nit, I think a change got snuck in here which also is in #2288
html-aam/index.html
Outdated
| @@ -16676,7 +16710,7 @@ <h3>Acknowledgments</h3> | |||
| Add listing of individuals who have providing meaningful | |||
| contributions through commenting that have impacted the specification. | |||
| --></div> | |||
| <div data-include="https://rawgit.com/w3c/aria/master/../common/acknowledgements/funders.html" data-include-replace="true"></div> | |||
| <div data-include="../common/acknowledgements/funders.html" data-include-replace="true"></div> | |||
There was a problem hiding this comment.
This change is also landing here: https://github.com/w3c/aria/pull/2288/files#diff-5c3c8936e81538898c83ae11f5271e9ae9324925713a3b03aca58cbd2a3c3014
so it might cause a conflict
There was a problem hiding this comment.
I meant to approve but I accidentally commented -- the only thing is: #2305 (comment)
spectranaut
changed the title
|
Hi @spectranaut <div data-include="https://rawgit.com/w3c/aria/master/../common/acknowledgements/funders.html" data-include-replace="true"></div>I think we should replace it with I've replaced it here, left https://github.com/w3c/aria/pull/2288/files#diff-5c3c8936e81538898c83ae11f5271e9ae9324925713a3b03aca58cbd2a3c3014 intact. |
Preview | Diff