-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent use of "group" role #1478
Comments
testing re: grouping of I don't have commentary on the other points, other than they're different widgets, so different allowances don't seem too out of left field to me? I rue the day I would want a |
I'm sure there are reasons for each of them being different. Really what I'm asking is are those reasons good enough for each type of list to have a different relationship to the It seems a little risky to trust that every time someone sees fit to use |
@WilcoFiers assuming it can't be consistent due to the fact that it has to work differently in different contexts (which seems to be the case from the discussion) - how could we resolve this:
|
@jnurthen I thought I had figured it out and pretty much had posted to close the issue, then I looked a second time and now I think I'm even more confused than ever. Can you tell me which of these is/should be valid? A. If I look at the required children for Unless I'm misreading this, the required child roles for I think option A is the way every other group in ARIA works now. Grid, menu, table, listbox, etc. all have the group as a child of the container. None of them accept a group inside the item. I think the solution to this is to either prohibit, or to deprecate |
Yes, the definitions in ARIA 1.3 for tree and treeitem contradict each other. In ARIA 1.2 it is still clear: only variant A is correct. However, I think that variant B should be correct - based on nested lists in HTML ( |
Also, it should be explicitely clarified again why |
I don't think a nested list is the same as a group of items. If you needed to put a tree inside another tree for some reason, I think
My big request here would be not to allow group as a child of treeitem, but to require it as a child of tree. There are definitely more things that can be done for consistency. Ideally all list-like roles would support both |
@WilcoFiers I don't care which path is taken. The important thing would be to eliminate the inconsistency. Please note, however, that in my opinion none of your examples can be compared with tree, because, for example, a group is not needed in a menu at all, but the nesting in the menu is done in a different way. In this respect, tree is a special case. Theoretically, tree could also work without a group (like menu, nested HTML lists or via aria-level) |
I was working on dequelabs/axe-core#2897, when I fell down the
group
-role rabbit hole. It is pretty odd how in consistent it is, which makes using group unpredictable.Would it be possible to get consistent rules on how and where
group
is used? The most recent draft clears up a few things with the "contained by" / "containing" wording, but there is still a fair bit of inconsistency in the use ofgroup
, which makes it difficult to use.list
used to allowgroup
. It was removed, because apparentlylist > group > listitem
does not work.list > listitem > group > listitem
does seem to work (according to Use of group within list is unclear #1011), and seems to work in the exact same way thatgroup > treeitem
works which is allowed.menu
allowsgroup
as part ofmenu
, but not as part ofmenuitem
. That's the exact opposite of what you're supposed to do withgroup
ontree
.tablist
andassociationlist
do not seem to allow group. Which is also fairly unintuitive, especially so sincedl
in HTML does allow grouping through the use ofdl > div > dt/dd
. If there's any role for which having a group makes sense itsdl
.The text was updated successfully, but these errors were encountered: