-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code guide and move from wiki into manage repo space #3092
base: main
Are you sure you want to change the base?
Conversation
@OliverHabersetzer @a11ydoer @howard-e @jugglinmike ... any other interested persons ... When discussing #3060 in last Tuesday's meeting, I had proposed we both update the content and move the guide out of wiki so we can manage changes with pull requests. During the meeting, I proposed moving the code guide into the "About" section of the APG. Another option would be to move it into a docs directory in the repository. I don't know which is better. In this PR, I set up both options. Option 1: Move to about section
Option 2: Move to docs directory
Which way do people think we should go with this? |
Thanks a Lot. Ill start work on this on monday!
…________________________________
From: Matt King ***@***.***>
Sent: Sunday, August 11, 2024 3:23:34 AM
To: w3c/aria-practices ***@***.***>
Cc: Habersetzer, Oliver ***@***.***>; Assign ***@***.***>
Subject: Re: [w3c/aria-practices] Update code guide and move from wiki into manage repo space (PR #3092)
You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification>
Assigned #3092<#3092> to @OliverHabersetzer<https://github.com/OliverHabersetzer>.
—
Reply to this email directly, view it on GitHub<#3092 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BJGK3QPTWN4AYKJKGDP47VLZQ24JNAVCNFSM6AAAAABMKI3NJ6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTHAZTANRSGUYTCNA>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
As an alternate, this content is often put into https://github.com/w3c/aria-practices/blob/main/CONTRIBUTING.md, but that can get awkward if the guide gets too large. |
@nschonni wrote:
The guide is large. I also think it is a good idea have separate URIs for the two different kinds of info. The contributing page is related to licensing and copyrights for all contributors, not just code contributions. |
I don't find the W3C CONTRIBUTION.md as the normal format for projects. The file is intended to tell people how to contribute ideas or code to a repository. The GitHub docs cover that a little https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors Another example, where external pages are used https://github.com/nodejs/node/blob/main/CONTRIBUTING.md |
My preference is option 2, mainly because of a potential con to option 1. It being a part of the about page may be misconstrued as a strong suggestion to APG consumers on the style of how they should be implementing work in their respective codebases. That could open "unwanted" feedback on the code guide when being an authority on that doesn't seem to be the APG intends. At least according to the code guide currently.
It feels more commonplace to me for someone to view the CONTRIBUTING.md, which would have link to the code guide already a part of the repo as well, before starting their PR changes. |
@@ -0,0 +1,941 @@ | |||
<header class="masthead"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless this ends up targetting the web and needs it, the HTML should probably be removed. I think it's all fine with plain Markdown syntax
Just to give you some updates on the PR: my legal team asked me to wait before actually contributing my changes until they made their decision. Sorry for letting you wait. |
Resolve #3060 by:
Preview links
WAI Preview Link (Last built on Sun, 11 Aug 2024 01:13:34 GMT).