From 85ce26f0d558ab17cd2c436c40ad87eef31d0d7f Mon Sep 17 00:00:00 2001 From: Howard Edwards Date: Fri, 4 Feb 2022 10:50:37 -0500 Subject: [PATCH 1/4] generate-and-commit-files.yml change to account for deeper commit history and using source branch of PR for ref --- .github/workflows/generate-and-commit-files.yml | 12 ++++-------- .github/workflows/js-lint.yml | 2 +- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/.github/workflows/generate-and-commit-files.yml b/.github/workflows/generate-and-commit-files.yml index 865b37ac8..f566e87ba 100644 --- a/.github/workflows/generate-and-commit-files.yml +++ b/.github/workflows/generate-and-commit-files.yml @@ -12,7 +12,8 @@ jobs: steps: - uses: actions/checkout@v2 with: - ref: ${{ github.head_ref }} + ref: refs/pull/${{ github.event.pull_request.number }}/head + fetch-depth: 0 - name: Use Node.js uses: actions/setup-node@v1 @@ -22,12 +23,6 @@ jobs: - name: Install dependencies run: npm ci - # - name: Generate test files - # run: npm run create-all-tests - - # - name: Generate review files - # run: npm run review-tests - - name: Generate test and review files run: npm run build @@ -41,7 +36,8 @@ jobs: steps: - uses: actions/checkout@v2 with: - ref: ${{ github.head_ref }} + ref: refs/pull/${{ github.event.pull_request.number }}/head + fetch-depth: 0 - name: Use Node.js uses: actions/setup-node@v1 diff --git a/.github/workflows/js-lint.yml b/.github/workflows/js-lint.yml index d0d6e6f6b..86097ff6d 100644 --- a/.github/workflows/js-lint.yml +++ b/.github/workflows/js-lint.yml @@ -29,5 +29,5 @@ jobs: - name: Install dependencies run: npm ci - - name: Generate test files + - name: Run linter run: npm run lint From 4933a79c8d3bdbd377d3d519a6270bb937c95341 Mon Sep 17 00:00:00 2001 From: howard-e Date: Mon, 7 Feb 2022 13:17:13 +0000 Subject: [PATCH 2/4] Generate test and review files automatically --- build/index.html | 311 +++++++++--------- build/review/alert.html | 52 +-- build/review/banner.html | 116 +++---- build/review/breadcrumb.html | 68 ++-- build/review/checkbox-tri-state.html | 108 +++--- build/review/checkbox.html | 114 +++---- .../combobox-autocomplete-both-updated.html | 284 +++++++--------- build/review/combobox-select-only.html | 202 +++++------- build/review/command-button.html | 68 ++-- build/review/complementary.html | 100 ++---- build/review/contentinfo.html | 84 ++--- build/review/datepicker-spin-button.html | 92 ++---- build/review/disclosure-faq.html | 114 +++---- build/review/disclosure-navigation.html | 164 ++++----- build/review/form.html | 100 ++---- build/review/horizontal-slider.html | 92 ++---- build/review/main.html | 88 ++--- ...menu-button-actions-active-descendant.html | 104 +++--- build/review/menu-button-actions.html | 104 +++--- build/review/menubar-editor.html | 144 ++++---- build/review/meter.html | 70 ++-- build/review/minimal-data-grid.html | 261 +++++++-------- build/review/modal-dialog.html | 120 +++---- .../radiogroup-aria-activedescendant.html | 140 ++++---- build/review/radiogroup-roving-tabindex.html | 140 ++++---- build/review/rating-slider.html | 92 ++---- build/review/seek-slider.html | 92 ++---- build/review/switch.html | 108 +++--- build/review/tabs-manual-activation.html | 116 +++---- build/review/toggle-button.html | 108 +++--- build/review/vertical-temperature-slider.html | 92 ++---- 31 files changed, 1510 insertions(+), 2338 deletions(-) diff --git a/build/index.html b/build/index.html index 7b8afdd2f..6c67bb876 100644 --- a/build/index.html +++ b/build/index.html @@ -21,15 +21,6 @@ padding: .5em; } - td > p { - margin: 0; - } - - tr:not(:first-of-type) th { - padding: .5em; - text-align: left; - } - @@ -41,247 +32,247 @@

Test Patterns for Review

Pattern Index Page Review Page - Number of Tests + # of Tests Commit of Last Change - alert - Index - Review -

3

- 73f3498 Generate test and review files automatically + alert + Index + Review + 3 + 9ccc7888 Add Alert and Breadcrumb test plan titles (#529) - banner - Index - Review -

26

- 73f3498 Generate test and review files automatically + banner + Index + Review + 26 + 0c61f715 Revert "Update JAWS commands for banner landmark tests, in line with JAWS 2022 updates" (#602) - breadcrumb - Index - Review -

9

- 73f3498 Generate test and review files automatically + breadcrumb + Index + Review + 9 + a2434b1e Breadcrumb: fix misquoted strings in commands.csv (#540) - checkbox - Index - Review -

26

- 73f3498 Generate test and review files automatically + checkbox + Index + Review + 26 + c2df595d Move test plan titles for app from support.json to references.csv (#473) - checkbox-tri-state - Index - Review -

24

- 73f3498 Generate test and review files automatically + checkbox-tri-state + Index + Review + 24 + 091420a1 Add title reference field to each test plan (#521) - combobox-autocomplete-both-updated - Index - Review -

76

- 73f3498 Generate test and review files automatically + combobox-autocomplete-both-updated + Index + Review + 76 + 091420a1 Add title reference field to each test plan (#521) - combobox-select-only - Index - Review -

38

- 73f3498 Generate test and review files automatically + combobox-select-only + Index + Review + 38 + 091420a1 Add title reference field to each test plan (#521) - command-button - Index - Review -

9

- 73f3498 Generate test and review files automatically + command-button + Index + Review + 9 + 091420a1 Add title reference field to each test plan (#521) - complementary - Index - Review -

20

- 73f3498 Generate test and review files automatically + complementary + Index + Review + 20 + 03b8747f Create tests for APG design pattern example: Contentinfo Landmark (#549) - contentinfo - Index - Review -

16

- 73f3498 Generate test and review files automatically + contentinfo + Index + Review + 16 + 03b8747f Create tests for APG design pattern example: Contentinfo Landmark (#549) - datepicker-spin-button - Index - Review -

21

- 73f3498 Generate test and review files automatically + datepicker-spin-button + Index + Review + 21 + 0483d7ea Create tests for APG design pattern example: Date Picker Spin Button (#411) - disclosure-faq - Index - Review -

26

- 73f3498 Generate test and review files automatically + disclosure-faq + Index + Review + 26 + 091420a1 Add title reference field to each test plan (#521) - disclosure-navigation - Index - Review -

46

- 73f3498 Generate test and review files automatically + disclosure-navigation + Index + Review + 46 + b2ceec70 Remove Space from tests 45 and 46 in disclosure navigation test plan (#585) - form - Index - Review -

20

- 73f3498 Generate test and review files automatically + form + Index + Review + 20 + 53792c23 Create tests for APG design pattern example: Form Landmark (#551) - horizontal-slider - Index - Review -

21

- 73f3498 Generate test and review files automatically + horizontal-slider + Index + Review + 21 + 49e2a000 Create tests for APG design pattern example: Color Viewer Slider (#414) - main - Index - Review -

16

- 73f3498 Generate test and review files automatically + main + Index + Review + 16 + 4ed847af Create tests for APG design pattern example: Main Landmark (#553) - menu-button-actions - Index - Review -

26

- 73f3498 Generate test and review files automatically + menu-button-actions + Index + Review + 26 + 091420a1 Add title reference field to each test plan (#521) - menu-button-actions-active-descendant - Index - Review -

26

- 73f3498 Generate test and review files automatically + menu-button-actions-active-descendant + Index + Review + 26 + 091420a1 Add title reference field to each test plan (#521) - menubar-editor - Index - Review -

40

- 73f3498 Generate test and review files automatically + menubar-editor + Index + Review + 40 + 05c4cf59 Standardize code style (#484) - meter - Index - Review -

9

- 73f3498 Generate test and review files automatically + meter + Index + Review + 9 + 0177f9e7 Create tests for APG design pattern example: meter (#571) - minimal-data-grid - Index - Review -

55

- 73f3498 Generate test and review files automatically + minimal-data-grid + Index + Review + 55 + 091420a1 Add title reference field to each test plan (#521) - modal-dialog - Index - Review -

29

- 73f3498 Generate test and review files automatically + modal-dialog + Index + Review + 29 + 04ed13d5 Fix typo in modal-dialog metadata (#527) - radiogroup-aria-activedescendant - Index - Review -

39

- 73f3498 Generate test and review files automatically + radiogroup-aria-activedescendant + Index + Review + 39 + 091420a1 Add title reference field to each test plan (#521) - radiogroup-roving-tabindex - Index - Review -

39

- 73f3498 Generate test and review files automatically + radiogroup-roving-tabindex + Index + Review + 39 + 091420a1 Add title reference field to each test plan (#521) - rating-slider - Index - Review -

21

- 73f3498 Generate test and review files automatically + rating-slider + Index + Review + 21 + b5c67ace Create tests for APG design pattern example: Vertical Temperature Slider (#487) - seek-slider - Index - Review -

21

- 73f3498 Generate test and review files automatically + seek-slider + Index + Review + 21 + 22c9895b Create tests for APG design pattern example: Media Seek Slider (#488) - switch - Index - Review -

24

- 73f3498 Generate test and review files automatically + switch + Index + Review + 24 + d3b62389 Create tests for APG design pattern example: Switch (#543) - tabs-manual-activation - Index - Review -

29

- 73f3498 Generate test and review files automatically + tabs-manual-activation + Index + Review + 29 + 091420a1 Add title reference field to each test plan (#521) - toggle-button - Index - Review -

24

- 73f3498 Generate test and review files automatically + toggle-button + Index + Review + 24 + acc6cb13 Toggle Button: fix setup scripts to set state of button to 'pressed' in some cases which were previously not accounted for (#532) - vertical-temperature-slider - Index - Review -

21

- 73f3498 Generate test and review files automatically + vertical-temperature-slider + Index + Review + 21 + b5c67ace Create tests for APG design pattern example: Vertical Temperature Slider (#487) diff --git a/build/review/alert.html b/build/review/alert.html index ce380e134..8974d4462 100644 --- a/build/review/alert.html +++ b/build/review/alert.html @@ -21,37 +21,6 @@