Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage report page: broken link to collection of all current test plans #675

Closed
mcking65 opened this issue Apr 2, 2022 · 7 comments · Fixed by #676
Closed

Coverage report page: broken link to collection of all current test plans #675

mcking65 opened this issue Apr 2, 2022 · 7 comments · Fixed by #676
Assignees
Labels
bug Something isn't working

Comments

@mcking65
Copy link
Contributor

mcking65 commented Apr 2, 2022

The link to "collection of all current test plans" on the coverage report page is broken.

@mcking65 mcking65 added the bug Something isn't working label Apr 2, 2022
@jscholes jscholes assigned s3ththompson and unassigned jscholes Apr 3, 2022
@jscholes
Copy link
Contributor

jscholes commented Apr 3, 2022

@s3ththompson I think this was caused by the work to switch to Netlify in #621 and related PRs. As PAC don't have access to the Netlify account to obtain a URL to a master deployment, I've re-assigned this issue to yourself for the time being. Once that URL is available, please feel free to re-assign it back to me and I'm happy to update the metrics file.

As an aside, this may be a good opportunity to revisit the setup of infrastructure in this repo. Right now, GitHub Pages is being used, but the build deployment will be on Netlify which is a separate system.

@jscholes
Copy link
Contributor

jscholes commented Apr 3, 2022

CC @richnoah

@howard-e howard-e linked a pull request Apr 4, 2022 that will close this issue
@howard-e
Copy link
Contributor

howard-e commented Apr 4, 2022

... I think this was caused by the work to switch to Netlify in #621 and related PRs.

That's right. #676 has been submitted to address this @jscholes @mcking65

As an aside, this may be a good opportunity to revisit the setup of infrastructure in this repo. Right now, GitHub Pages is being used, but the build deployment will be on Netlify which is a separate system.

Good note, we've gone ahead and disabled the GitHub Pages workflow

@nschonni
Copy link
Contributor

nschonni commented Apr 4, 2022

GitHub pages is stull "on" for the repo https://w3c.github.io/aria-at/

@howard-e
Copy link
Contributor

howard-e commented Apr 4, 2022

GitHub pages is stull "on" for the repo https://w3c.github.io/aria-at/

Seems we have to remove the gh-pages branch to completely unpublish

@nschonni
Copy link
Contributor

nschonni commented Apr 4, 2022

Don't recall exactly, but I think you can leave the branch, but turn it off on the Settings page of the repo. But makes sense to get rid of the branch if you're not using it 😄

@howard-e
Copy link
Contributor

howard-e commented Apr 4, 2022

I vaguely remember that being possible as well (turning it off) but doesn't seem to be the case https://docs.github.com/en/pages/getting-started-with-github-pages/unpublishing-a-github-pages-site#unpublishing-a-project-site

If a gh-pages branch exists in the repository, delete the gh-pages branch

So we can go ahead and make those changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants