From 24efd4889dd3373417d25c069acecfec75c7bd9d Mon Sep 17 00:00:00 2001 From: Rebecca Meritz Date: Tue, 1 Dec 2020 12:07:09 -0500 Subject: [PATCH] Change format of generated test files to be comparable (#333) * Replace scripts.js file with inlined file * Remove and inline test json file * Remove fetching command.json via ajax call * Replace command.json with inlining one command * Add back generated files They are needed to generate the reivew pages. * Stop github action from running twice I think it once running once for all PRs and once for all PR targets (which is to support forks). And then the two commits were collbering each other. * Generate test and review files automatically Co-authored-by: rmeritz --- .../workflows/generate-and-commit-files.yml | 2 +- index.html | 6 +- review/checkbox.html | 52 ++--- review/combobox-autocomplete-both.html | 60 +++--- review/menubar-editor.html | 80 +++---- scripts/create-example-tests.js | 55 ++--- tests/checkbox/scripts.js | 44 ---- ...avigate-to-unchecked-checkbox-reading.html | 81 +++++++- ...ate-to-unchecked-checkbox-interaction.html | 81 +++++++- ...ate-to-unchecked-checkbox-interaction.html | 80 ++++++- ...-navigate-to-checked-checkbox-reading.html | 84 +++++++- ...igate-to-checked-checkbox-interaction.html | 84 +++++++- ...igate-to-checked-checkbox-interaction.html | 83 +++++++- .../test-07-operate-checkbox-reading.html | 54 ++++- .../test-08-operate-checkbox-interaction.html | 54 ++++- .../test-09-operate-checkbox-interaction.html | 53 ++++- ...st-10-read-unchecked-checkbox-reading.html | 65 +++++- ...1-read-unchecked-checkbox-interaction.html | 65 +++++- ...2-read-unchecked-checkbox-interaction.html | 64 +++++- ...test-13-read-checked-checkbox-reading.html | 67 +++++- ...-14-read-checked-checkbox-interaction.html | 67 +++++- ...-15-read-checked-checkbox-interaction.html | 66 +++++- .../test-16-read-checkbox-group-reading.html | 58 +++++- ...st-17-read-checkbox-group-interaction.html | 58 +++++- ...st-18-read-checkbox-group-interaction.html | 57 ++++- ...tially-through-checkbox-group-reading.html | 60 +++++- ...ly-through-checkbox-group-interaction.html | 59 +++++- ...-navigate-into-checkbox-group-reading.html | 80 ++++++- ...igate-into-checkbox-group-interaction.html | 80 ++++++- ...igate-into-checkbox-group-interaction.html | 79 ++++++- ...avigate-out-of-checkbox-group-reading.html | 64 +++++- ...ate-out-of-checkbox-group-interaction.html | 64 +++++- ...ate-out-of-checkbox-group-interaction.html | 63 +++++- tests/combobox-autocomplete-both/scripts.js | 195 ------------------ .../test-01-navigate-to-combobox-reading.html | 80 ++++++- ...-navigate-by-line-to-combobox-reading.html | 54 ++++- ...t-03-navigate-to-combobox-interaction.html | 80 ++++++- .../test-04-read-combobox-reading.html | 63 +++++- .../test-05-read-combobox-interaction.html | 63 +++++- .../test-06-navigate-to-combobox-reading.html | 93 ++++++++- ...t-07-navigate-to-combobox-interaction.html | 93 ++++++++- .../test-08-read-combobox-reading.html | 76 ++++++- .../test-09-read-combobox-interaction.html | 76 ++++++- .../test-10-navigate-to-combobox-reading.html | 94 ++++++++- ...-navigate-by-line-to-combobox-reading.html | 58 +++++- ...t-12-navigate-to-combobox-interaction.html | 94 ++++++++- .../test-13-read-combobox-reading.html | 77 ++++++- .../test-14-read-combobox-interaction.html | 77 ++++++- ...x-with-keys-that-switch-modes-reading.html | 46 ++++- .../test-16-activate-combobox-reading.html | 53 ++++- .../test-17-open-combobox-interaction.html | 62 +++++- .../test-18-close-combobox-interaction.html | 57 ++++- ...est-19-activate-states-button-reading.html | 61 +++++- ...20-activate-states-button-interaction.html | 60 +++++- ...est-21-activate-states-button-reading.html | 57 ++++- ...22-activate-states-button-interaction.html | 57 ++++- ...-into-popup-from-combobox-interaction.html | 66 +++++- ...24-type-in-empty-combobox-interaction.html | 66 +++++- ...25-navigate-listbox-popup-interaction.html | 62 +++++- ...-read-option-in-listbox-popup-reading.html | 66 +++++- ...d-option-in-listbox-popup-interaction.html | 66 +++++- ...28-choose-combobox-option-interaction.html | 70 ++++++- .../test-29-cancel-selection-interaction.html | 70 ++++++- ...ret-movement-from-listbox-interaction.html | 85 +++++++- tests/menubar-editor/scripts.js | 150 -------------- .../test-01-navigate-to-menubar-reading.html | 79 ++++++- .../test-02-activate-menubar-reading.html | 46 ++++- .../test-03-tab-to-menubar-reading.html | 69 ++++++- ...st-04-navigate-to-menubar-interaction.html | 79 ++++++- ...st-05-navigate-to-menubar-interaction.html | 78 ++++++- ...vigate-to-menuitem-in-menubar-reading.html | 70 ++++++- ...te-to-menuitem-in-menubar-interaction.html | 73 ++++++- ...te-to-menuitem-in-menubar-interaction.html | 72 ++++++- ...-open-menuitem-in-menubar-interaction.html | 66 +++++- ...-open-menuitem-in-menubar-interaction.html | 65 +++++- ...1-open-submenu-of-menubar-interaction.html | 73 ++++++- ...2-open-submenu-of-menubar-interaction.html | 72 ++++++- ...-close-submenu-of-menubar-interaction.html | 62 +++++- ...-close-submenu-of-menubar-interaction.html | 61 +++++- ...-menuitemradio-in-submenu-interaction.html | 67 +++++- ...-menuitemradio-in-submenu-interaction.html | 66 +++++- ...-menuitemradio-in-submenu-interaction.html | 67 +++++- ...-menuitemradio-in-submenu-interaction.html | 66 +++++- ...nuitemcheckbox-in-submenu-interaction.html | 71 ++++++- ...nuitemcheckbox-in-submenu-interaction.html | 70 ++++++- ...nuitemcheckbox-in-submenu-interaction.html | 71 ++++++- ...nuitemcheckbox-in-submenu-interaction.html | 70 ++++++- ...t-23-read-menuitem-in-menubar-reading.html | 76 ++++++- ...-read-menuitem-in-menubar-interaction.html | 79 ++++++- ...-read-menuitem-in-menubar-interaction.html | 78 ++++++- ...radio-in-a-group-in-a-submenu-reading.html | 79 ++++++- ...o-in-a-group-in-a-submenu-interaction.html | 79 ++++++- ...o-in-a-group-in-a-submenu-interaction.html | 78 ++++++- ...radio-in-a-group-in-a-submenu-reading.html | 79 ++++++- ...o-in-a-group-in-a-submenu-interaction.html | 79 ++++++- ...o-in-a-group-in-a-submenu-interaction.html | 78 ++++++- ...ckbox-in-a-group-in-a-submenu-reading.html | 79 ++++++- ...x-in-a-group-in-a-submenu-interaction.html | 79 ++++++- ...x-in-a-group-in-a-submenu-interaction.html | 78 ++++++- ...ckbox-in-a-group-in-a-submenu-reading.html | 79 ++++++- ...x-in-a-group-in-a-submenu-interaction.html | 79 ++++++- ...x-in-a-group-in-a-submenu-interaction.html | 78 ++++++- ...isabled-menuitem-in-a-submenu-reading.html | 75 ++++++- ...led-menuitem-in-a-submenu-interaction.html | 75 ++++++- ...led-menuitem-in-a-submenu-interaction.html | 74 ++++++- 105 files changed, 6032 insertions(+), 1378 deletions(-) delete mode 100644 tests/checkbox/scripts.js delete mode 100644 tests/combobox-autocomplete-both/scripts.js delete mode 100644 tests/menubar-editor/scripts.js diff --git a/.github/workflows/generate-and-commit-files.yml b/.github/workflows/generate-and-commit-files.yml index ea1b9d18c..3169972d7 100644 --- a/.github/workflows/generate-and-commit-files.yml +++ b/.github/workflows/generate-and-commit-files.yml @@ -1,6 +1,6 @@ name: Generate and Commit Files -on: [pull_request, pull_request_target] +on: [pull_request_target] jobs: generate-and-commit-files: diff --git a/index.html b/index.html index 32dbf2e33..53da04336 100644 --- a/index.html +++ b/index.html @@ -40,7 +40,7 @@

Test Patterns for Review

Index Review 26 - a9c11e8 Execute setup script on popup for review page + b2d158a Stop github action from running twice @@ -48,7 +48,7 @@

Test Patterns for Review

Index Review 30 - a9c11e8 Execute setup script on popup for review page + b2d158a Stop github action from running twice @@ -56,7 +56,7 @@

Test Patterns for Review

Index Review 40 - a9c11e8 Execute setup script on popup for review page + b2d158a Stop github action from running twice diff --git a/review/checkbox.html b/review/checkbox.html index 6d66ef06d..65e1aa3fb 100644 --- a/review/checkbox.html +++ b/review/checkbox.html @@ -187,7 +187,7 @@

Test 1: Navigate to an unchecked checkbox in reading mode