Mark as final button should not be shown in the test queue report status column unless at least one run of a plan is complete

[mcking65]

#755 suppresses display of the "mark as Final" button when there are conflicts, but the button still appears in other circumstances where a report can't be finalized. In those other circumstances, an error dialog is shown when the button is activated. This creates odd inconsistencies, such as the following, where one row has the button and another does not, but it is not useful or needed in either row.

Change the display logic so that "Mark as Final" is shown only if all the following are true:

• The user is an admin
• There is at least one complete run
• There are no incomplete runs
• There are 0 conflicts

An incomplete run is a run that is assigned and does not have a complete set of results.

If a report has one complete run and no incomplete runs, the button could appear. Assigning another person to run the test plan for the same report would cause the button to disappear.

If a report has some incomplete runs, deleting all the incomplete runs would cause the button to appear as long as there is at least one complete run and no conflicts.

I don't think we want to force two complete runs even though that is what we normally require. The admin should be able to decide if one run is sufficient, which we may allow in the event of automated re-runs where 0 differences from prior comparables were present.

[mcking65]

@jscholes would like to make sure you concur with all the above requirements.

[jscholes]

@mcking65 Yes, these look good to me.

[alflennik]

PR #807 will make the button appear and disappear at the correct times, but only with the current behavior of the system, it does not implement a requirement that all tests be filled out. We should keep this issue open until that larger feature is implemented.

[mcking65]

Tested in sandbox and verified that mark as final is only available when:

• There is at least one complete run
• There are no incomplete runs
• There are 0 conflicts

I have forgotten how to login with another role that is not admin. I did not verify that the button is only when the above are all true and the user is an admin. Assuming no regression in availability based on role, this is fixed. Thank you, thank you!!!

This issue can be closed when the fix is deployed to prod.