Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test plan version history shows incorrect text when a plan in R&D Complete phase is deprecated #778

Closed
mcking65 opened this issue Sep 19, 2023 · 2 comments · Fixed by #781
Labels
bug Something isn't working

Comments

@mcking65
Copy link

If a test plan is deprecated before starting draft review, the text in the "Latest Phase" column of the "Version Summary" table is:

Deprecated during R&D review

image

There is not a phase named "R&D Review".

However, following the spec I wrote in #719 would have not been much better. The spec says to use the text "Deprecated during PHASE_NAME", which would have created the text:

Deprecated during R&D

That wouldn't have been accurate and would have been confusing. The spec I wrote in in #719 is fine if the phase is draft review or candidate review, but it is not very good for R&D or Recommended.

I recommend using the following text strings for when plans are deprecated in either of these two phases.

If a test plan is deprecated after R&D is complete and before draft review is started, use the string "Deprecated before draft review started".

If a test plan is deprecated after it has been approved as recommended, use the string "Deprecated after being approved as recommended".

@mcking65
Copy link
Author

Thank you @alflennik and @howard-e! This is working well in staging now.

@ccanash
Copy link
Contributor

ccanash commented Oct 3, 2023

Released to prod

@ccanash ccanash closed this as completed Oct 3, 2023
@ccanash ccanash moved this from In staging/sandbox to In production / Completed in MVP support of ARIA-AT Working Mode by ARIA-AT App - 2023 H1 Project Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants