Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of table that presents test results for each command #733

Closed
mcking65 opened this issue Aug 5, 2023 · 2 comments · Fixed by #765
Closed

Improve readability of table that presents test results for each command #733

mcking65 opened this issue Aug 5, 2023 · 2 comments · Fixed by #765
Assignees
Labels
enhancement New feature or request

Comments

@mcking65
Copy link

mcking65 commented Aug 5, 2023

Problem description

The design of the table that presents results for each command in a test creates several problems:

Image of Firefox results table for radio test 17 in candidate review

This table is used in:

Key assumptions

Note:

It assumes that both "no output" and "incorrect output" verdicts are presented as failed assertions as is described in #735.

Solution proposal

Instead of presenting results for all commands in a single table, present results for each command in a separate section containing the following elements.

  1. Heading with:

    • Text: "COMMAND_NAME Results: X passed, Y failed
    • Example: Insert+UpArrow Results: 4 passed, 2 failed
    • if the command is a sequence, display it as "COMMAND1 then COMMAND2 then ... Results: X passed, Y failed"
    • Example: "Down Arrow then Down Arrow Results: 4 passed, 2 failed
      *Note: In current reports, the word "then" is preceded by a comma. Do not include a comma.
    • Note: Heading level should be determined by context. Using current IA, it would be level 3 in the test runner, candidate review, and report pages.
  2. BlockQuote labeled "AT_NAME Response" and contains the output string.

  3. Table captioned "COMMAND_NAME Results" and columns:

    • Priority: ASSERTION_PRIORITY
    • Assertion: ASSERTION_TEXT
    • Verdict: Passed | Failed
    • Rows are sorted by priority descending, then result (failures then passes), then assertion order. Assertion order refers to the order of assertion columns in the tests.csv file.
  4. A paragraph element that:

    • If no unexpected behaviors were reported, contains text: "Unexpected behaviors: None"
    • If unexpected behaviors were reported, contains text "Unexpected behaviors:", and it is followed by an unordered list containing the behaviors.

Additional integration requirements

In the test runner and candidate review experiences, the results tables are preceded by a level 2 heading with text:

Test Result: PASS
or
Test Result: FAIL

Change this heading text to:

Test Results (x passed, y failed)

Where x and y represent the total number of passing and failing assertions across all commands in the test.

Currently, on report pages, the test results table is preceded by a level 2 heading with text:

Details for test:TEST_NAME

Example:

Details for test:Trigger an alert in reading mode

Change the text of this heading to:

TEST_NAME (X passed, y failed)

Example using current JAWS/Chrome results:

Trigger an alert in reading mode (2 passed, 2 failed)

Mockup

Here is a zip containing an HTML mockup with data from the radio group report.
TestResultsTableMockupForIssue733.zip

@mcking65
Copy link
Author

mcking65 commented Aug 5, 2023

@jscholes

We'll discuss in our Tuesday meeting. If possible, please preview before we meet.

@howard-e howard-e linked a pull request Sep 6, 2023 that will close this issue
@alflennik alflennik reopened this Oct 5, 2023
@ccanash ccanash moved this from In sandbox to In production / Completed in Refactor ARIA-AT test structure and test result presentation project Oct 16, 2023
@ccanash
Copy link
Contributor

ccanash commented Oct 16, 2023

Closing as released to production

@ccanash ccanash closed this as completed Oct 16, 2023
@ccanash ccanash moved this from In Progress to In production / Completed in Refactor ARIA-AT test structure and test result presentation project Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

4 participants