-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache and Request objects #624
Comments
Is it reasonable to leave off the Request body if we want to support POST methods in the Cache in the future? See this previous comment from @jakearchibald: |
Yeah.
I've heard people ask for a way to store post requests, especially if (a clone) failed to complete, maybe indexedDB is a better place for these, although you run into the same clones issue. |
They just want to store the POST requests, but not match on them? |
Yeah, that's another reason for them to not be in the cache |
Since the cache does not support anything but |
It's not entirely clear to me how this works right now. E.g. does
keys()
always return clones? (The text forkeys()
is most certainly wrong.)I think that perhaps we should introduce
RequestKey
or some such and introduce a mixin thatRequest
andRequestKey
can share. And ways to create aRequestKey
from aRequest
(and vice versa?). That way caches never have to deal with request that has an associated body.The text was updated successfully, but these errors were encountered: