-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FedCM IdP error responses #601
Comments
id_assertion_endpoint
error responses
Oh, I realize we are yet to merge the PR for the error API to the spec :( see #498. So we do allow surfacing an error from the ID assertion endpoint. However, I don't think we allow IdentityProvider.resolve() to use this kind of error, so cannot surface it from continuation API. |
Since the same kind of errors may be the result of the assertion endpoint being called directly as well as its subsequent interactions I'd say both should allow the same error shape to be returned. |
Note that the continuation API is still under development. This seems reasonable to me. @cbiesinger feature request :) |
Yes adding something like IdentityProvider.reject would make a lot of sense |
+1. |
Currently the IdP has no way to return errors back to FedCM from neither the
id_assertion_endpoint
nor from within the Continuation API popup.The only fulfillable response from is 200 OK that matches
IdentityProviderToken
from the endpoint orIdentityProvider.resolve
from the Continuation API popup.I believe there should be an error format specified, such as one that allows a 400-499 status code range and fields (conveniently borrowed format from OAuth) that would fulfill the RP's
credential.get()
, likely with a rejection?The Continuation API version of this, used e.g. when the end-user clicks on "cancel" / "abort" in the IdP prompt.
The rejection should allow discerning between IdP errors and FedCM errors, such as with specific Error subclasses
FedCMIdentityProviderError
so that the client can make a call such asThe text was updated successfully, but these errors were encountered: