Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention the proofValue and nonce values must be base64 encoded #51

Closed
TimoGlastra opened this issue Apr 28, 2021 · 2 comments
Closed

Mention the proofValue and nonce values must be base64 encoded #51

TimoGlastra opened this issue Apr 28, 2021 · 2 comments
Labels
question Further information is requested

Comments

@TimoGlastra
Copy link
Contributor

As the title suggests. It is not clear from reading the spec that the values must be base64 encoded

@kdenhartog
Copy link
Member

kdenhartog commented Apr 29, 2021

Agree the encoding should be normatively stated. I think it may be useful for us to look at multibase encoding or base64url no padding as well which is discussed in #16

We should first decide what encoding format we want to do and then make sure that it's commonly used.

@msporny is this something that we want to define at the LDS layer? E.g. all suites must use the same encoding format?

@kdenhartog kdenhartog assigned kdenhartog and unassigned kdenhartog Apr 29, 2021
@kdenhartog kdenhartog added the question Further information is requested label Apr 29, 2021
@OR13
Copy link
Contributor

OR13 commented Apr 25, 2023

This is stale, proofValue must be multibase.

@OR13 OR13 closed this as completed Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants