Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing pseudo headers in draft version #11 examples #68

Open
hrobache opened this issue Jun 3, 2019 · 0 comments · May be fixed by #69
Open

Missing pseudo headers in draft version #11 examples #68

hrobache opened this issue Jun 3, 2019 · 0 comments · May be fixed by #69
Labels
quality Clarity, consistency, effectiveness

Comments

@hrobache
Copy link

hrobache commented Jun 3, 2019

I have a doubt about § C.3. (All headers test)

The signing string is specified as this:

(request-target): post /foo?param=value&pet=dog
host: example.com
date: Sun, 05 Jan 2014 21:31:40 GMT
content-type: application/json
digest: SHA-256=X48E9qOokqqrvdts8nOJRJN3OWDUoyWxBf7kbu9DBPE=
content-length: 18

Aren't pseudo-headers (created) and (expires) missing? If yes, I guess the signature value should be fixed as well.
ioggstream added a commit to ioggstream/http-signatures that referenced this issue Jun 3, 2019
@ioggstream
Fix w3c-ccg#68: missing lines in signature string.
5a1c75c 
Add missing virtual headers in signature string: `(created) (expires)`.
@ioggstream ioggstream linked a pull request Jun 3, 2019 that will close this issue
Open
@liamdennehy liamdennehy added the quality Clarity, consistency, effectiveness label Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
quality Clarity, consistency, effectiveness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #68: missing lines in signature string example. ioggstream/http-signatures
2 participants
@liamdennehy @hrobache