Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit rejection mode vs simple exceptions to reduce false positives #12

Open
liamdennehy opened this issue Aug 9, 2019 · 1 comment

Comments

@liamdennehy
Copy link
Contributor

Throwing my v10-compliant implementation at this suite has generated a lot of false positives in terms of compliance. The phrase "MUST produce an error" appears to indicate any failure (non-zero exit) is an appropriate exception, while my implementation simply doesn't understand the requested operation e.g. hs2019 - correct for v10.

Any "MUST produce an error" case should also require the application to emit an explicit message stating this is for protocol compliance reasons, e.g. starting with Refused: , so that these false positives are not counted as compliant.

@aljones15
Copy link
Collaborator

One idea we had was exit codes actually.
Currently we have 2 exit codes 0 and 1.
I think we could expand it so we have 4:

0 for success
1 for expected error
2 for unexpected error
3 for not implemented

@liamdennehy liamdennehy mentioned this issue Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants