fix[docs]: fix clipped endAuction method in example section
#3969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3969 +/- ##
==========================================
- Coverage 90.87% 90.80% -0.07%
==========================================
Files 95 95
Lines 14458 14458
Branches 3207 3207
==========================================
- Hits 13138 13129 -9
- Misses 912 921 +9
Partials 408 408 ☔ View full report in Codecov by Sentry. |
fubuloubu
approved these changes
Apr 24, 2024
fubuloubu
changed the title
endAuction method in vyper-by-example.rstendAuction method in vyper by example
charles-cooper
approved these changes
Apr 24, 2024
charles-cooper
changed the title
endAuction method in vyper by exampleendAuction method in vyper by example
charles-cooper
changed the title
endAuction method in vyper by exampleendAuction method in docs example
charles-cooper
changed the title
endAuction method in docs exampleendAuction method in example section
electriclilies
added a commit
to electriclilies/vyper
that referenced
this pull request
Apr 27, 2024
…ang#3969) Show entire endAuction method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The
endAuctionmethod invyper-by-example.rstgets truncated before the beneficiary is sent the highest bid. This updates the line numbers to show the entire methodHow I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture