Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[docs]: fix some typos #3855

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Conversation

wellweek
Copy link
Contributor

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.65%. Comparing base (e1adb7b) to head (dfce38b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3855      +/-   ##
==========================================
- Coverage   90.86%   90.65%   -0.22%     
==========================================
  Files          95       95              
  Lines       14454    14454              
  Branches     3205     3205              
==========================================
- Hits        13134    13103      -31     
- Misses        912      936      +24     
- Partials      408      415       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper
Copy link
Member

this seems fine, although we have been getting a number of "docs/typo" fixes lately. is it airdrop spam?

@wellweek
Copy link
Contributor Author

this seems fine, although we have been getting a number of "docs/typo" fixes lately. is it airdrop spam?

No.. Of course

@charles-cooper charles-cooper changed the title chore: fix some comments chore[docs]: fix some comments Apr 20, 2024
@charles-cooper charles-cooper changed the title chore[docs]: fix some comments chore[docs]: fix some typos Apr 20, 2024
@charles-cooper charles-cooper enabled auto-merge (squash) April 20, 2024 12:53
@charles-cooper charles-cooper merged commit 80708e6 into vyperlang:master Apr 20, 2024
148 checks passed
@charles-cooper
Copy link
Member

merging, although i want to point out that @wellweek and @JohnEndson (who opened the duplicate PR above #3897) both are recently created accounts who are going around and creating a bunch of docs/typo PRs across many high-ish profile repositories. nothing wrong with that, but with the recent well-publicized supply-chain attack on xz, i have become somewhat paranoid.

i wonder if this is somehow a phishing attempt to try to gain CI access to repositories in the supply-chain (as github repos typically have a rule where PRs opened by previous contributors automatically run CI).

archiving these in case they go anywhere:
https://web.archive.org/web/20240420130953/https://github.com/wellweek?tab=overview&from=2024-03-01&to=2024-03-31
https://web.archive.org/web/20240420131109/https://github.com/JohnEndson?tab=overview&from=2024-03-01&to=2024-03-31
Screenshot from 2024-04-20 09-13-15
Screenshot from 2024-04-20 09-13-19

electriclilies pushed a commit to electriclilies/vyper that referenced this pull request Apr 27, 2024
@charles-cooper charles-cooper mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants