Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comptime check for uint2str input #3671

Merged

Conversation

iFrostizz
Copy link
Contributor

What I did

Closes #3641

How I did it

How to verify it

Commit message

Fix type check for uint2str at compile-time, closes #3641

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4dd47e3) 89.61% compared to head (339143a) 90.23%.
Report is 5 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3671      +/-   ##
==========================================
+ Coverage   89.61%   90.23%   +0.62%     
==========================================
  Files          80       79       -1     
  Lines       11343    11260      -83     
  Branches     2553     2545       -8     
==========================================
- Hits        10165    10161       -4     
+ Misses        791      712      -79     
  Partials      387      387              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper merged commit 7c74aa2 into vyperlang:master Dec 9, 2023
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Builtin Typecheck
3 participants