Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add abi_types unit tests #3662

Merged
merged 7 commits into from
Nov 7, 2023

Conversation

iFrostizz
Copy link
Contributor

What I did

Filling some coverage holes regarding abi types that cannot be hit with integration testing because the type checker would have, well, caught it

How I did it

Adding a parametrized unit test

How to verify it

Commit message

add abi types unit tests

Description for the changelog

add abi types unit tests

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@iFrostizz
Copy link
Contributor Author

Note: this is about #3647 but won't probably make it reach 90%

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the test! maybe there is a better place for this test btw? maybe tests/abi_types/test_invalid_abi_types.py

@iFrostizz
Copy link
Contributor Author

moved the logic for 2-dimensionnal parametrization inside the test, changed variants to a tuple, and move the file to the new location !

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Merging #3662 (22272ae) into master (9ce56e7) will increase coverage by 0.46%.
Report is 3 commits behind head on master.
The diff coverage is 88.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #3662      +/-   ##
==========================================
+ Coverage   89.14%   89.61%   +0.46%     
==========================================
  Files          85       80       -5     
  Lines       11364    11343      -21     
  Branches     2585     2553      -32     
==========================================
+ Hits        10131    10165      +34     
+ Misses        822      791      -31     
+ Partials      411      387      -24     
Files Coverage Δ
vyper/exceptions.py 97.36% <100.00%> (+0.02%) ⬆️
vyper/abi_types.py 90.47% <87.50%> (+7.14%) ⬆️

... and 14 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@iFrostizz
Copy link
Contributor Author

as you advised on Discord, because CompilerPanic is likely to be the thing that this test tests, it's now not a param anymore

vyper/exceptions.py Outdated Show resolved Hide resolved
Co-authored-by: Charles Cooper <[email protected]>
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@charles-cooper charles-cooper enabled auto-merge (squash) November 7, 2023 22:34
vyper/exceptions.py Fixed Show fixed Hide fixed
@charles-cooper charles-cooper enabled auto-merge (squash) November 7, 2023 23:06
@charles-cooper charles-cooper merged commit 806dd90 into vyperlang:master Nov 7, 2023
83 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants