-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add abi_types unit tests #3662
add abi_types unit tests #3662
Conversation
Note: this is about #3647 but won't probably make it reach 90% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the test! maybe there is a better place for this test btw? maybe tests/abi_types/test_invalid_abi_types.py
moved the logic for 2-dimensionnal parametrization inside the test, changed variants to a tuple, and move the file to the new location ! |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #3662 +/- ##
==========================================
+ Coverage 89.14% 89.61% +0.46%
==========================================
Files 85 80 -5
Lines 11364 11343 -21
Branches 2585 2553 -32
==========================================
+ Hits 10131 10165 +34
+ Misses 822 791 -31
+ Partials 411 387 -24
... and 14 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
as you advised on Discord, because |
Co-authored-by: Charles Cooper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
What I did
Filling some coverage holes regarding abi types that cannot be hit with integration testing because the type checker would have, well, caught it
How I did it
Adding a parametrized unit test
How to verify it
Commit message
add abi types unit tests
Description for the changelog
add abi types unit tests
Cute Animal Picture