-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop evm versions through istanbul #3470
chore: drop evm versions through istanbul #3470
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3470 +/- ##
===========================================
- Coverage 89.30% 53.16% -36.15%
===========================================
Files 84 84
Lines 10792 10778 -14
Branches 2461 2456 -5
===========================================
- Hits 9638 5730 -3908
- Misses 756 4534 +3778
- Partials 398 514 +116
... and 60 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
drop pre-istanbul versions. per VIP-3365, we could drop through paris, but since this is the first time starting to enforce this policy, we don't want to drop too many versions at once.
What I did
drop pre-istanbul versions. actually, per #3365, we could drop everything pre-paris, but brownie still defaults to
evm_version: istanbul
, and i'm not sure we want to break that. (actually, maybe we do want to drop istanbul because then brownie users would stop trying to verify contracts compiled for istanbul, and would instead explicitly set the evm version to something more recent).How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture