-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: default code offset = 3 #3454
feat: default code offset = 3 #3454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm i think this breaks some tests, also needs a docs update
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3454 +/- ##
==========================================
- Coverage 84.93% 84.89% -0.05%
==========================================
Files 92 92
Lines 13685 13734 +49
Branches 3074 3078 +4
==========================================
+ Hits 11623 11659 +36
- Misses 1572 1586 +14
+ Partials 490 489 -1 ☔ View full report in Codecov by Sentry. |
alright i fixed the tests and updated the docs. since this is a breaking change (and we don't really want to break user code with 'patch' changes), going to hold off on this until the 0.4.0 series. also i'm not a huge fan of the duplicated code in the new test case - it would be nice to think of a way around that. |
i fixed the merge conflicts and updated the test so it passes. @pcaversaccio @fubuloubu want to take a look in case i missed anything? |
What I did
Set default code offset for blueprint contracts to 3
How I did it
Just change the default value from
zero_value
(which isIRnode.from_list(0, typ=UINT256_T)
) toIRnode.from_list(3, typ=UINT256_T)
.How to verify it
Added a test that simply uses no code_offset for initcode with the EIP5202 magic val appended at the top
Commit message
Sets default code offset to 3 (instead of 0).
Description for the changelog
Update: Sets default code offset to 3 (instead of 0).
Cute Animal Picture