Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use revert opcode for clamps as well. #527

Closed
jacqueswww opened this issue Nov 29, 2017 · 0 comments
Closed

Use revert opcode for clamps as well. #527

jacqueswww opened this issue Nov 29, 2017 · 0 comments

Comments

@jacqueswww
Copy link
Contributor

jacqueswww commented Nov 29, 2017 •
edited
Loading

What's your issue about?

As part of PR: #492 and VIP: #478. We opted use REVERT opcode for the assert statement. By extension we should use the REVERT opcode for the clamp statements as well.

How can it be fixed?

Fix the LLL in compile_lll.py:161, to use REVERT instead (instead of illegal jump).

Cute Animal Picture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacqueswww @DavidKnott