Fix unit tests #137
Merged
Fix unit tests #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit db8f14a.
DanielSchiavini
commented
Feb 7, 2024
| @@ -474,6 +473,9 @@ def fork_rpc(self, rpc=None, reset_traces=True, block_identifier="safe", **kwarg | |||
| def _fork_mode(self): | |||
| return self.vm.__class__._state_class.account_db_class == AccountDBFork | |||
|
|
|||
| def _set_account_db_class(self, account_db_class: type): | |||
There was a problem hiding this comment.
just moved it close to _fork_mode
| self.vm.patch = VMPatcher(self.vm) | ||
|
|
||
| # revert any previous AccountDBFork patching | ||
| self._set_account_db_class(AccountDB) |
There was a problem hiding this comment.
this change got lost and broke anvil, so the error did not need to be swallowed
This reverts commit 171e00b.
DanielSchiavini
added a commit
that referenced
this pull request
Feb 9, 2024
Set chain ID via BrowserSigner + #137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed the tests. Removed error swallowing.
How I did it
By restoring the AccountDB class when resetting the env.
How to verify it
Unit tests should be green.
Description for the changelog
n/a
Cute Animal Picture