Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display storage dump with state before revert #123

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Conversation

DanielSchiavini
Copy link
Collaborator

What I did

How I did it

  • Investigated how py-evm handles the snapshots
    • However, the data gets completely deleted after revert. To save all the deleted data would be quite cumbersome
  • Instead of saving the whole journal, it makes more sense to only save the data we need when we need it
  • Therefore I only extract the repr(contract) before the revert, as this is the information used
  • Alternatively we could extract more data at this point (e.g. storage.dump())
  • The implementation is in the environment as this is specific to py-evm

How to verify it

  • Test is included; Please advise on extra test/corner cases that I did not identify.

Description for the changelog

  • Display the storage dump with the state before the computation was reverted

Cute Animal Picture

image

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's roll back the changes to the CI for now

@charles-cooper charles-cooper merged commit 79b9859 into master Jan 31, 2024
8 of 10 checks passed
@charles-cooper charles-cooper deleted the 92/storage-dump branch January 31, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage dump is wrong after reversion
2 participants