Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle truncation properly with PPO #311

Closed
wants to merge 3 commits into from
Closed

Handle truncation properly with PPO #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a62a929
Handle truncation properly with PPO
vwxyzjn Nov 5, 2022
044d9c7
quick change
vwxyzjn Nov 12, 2022
3fee121
update
vwxyzjn Nov 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 20 additions & 19 deletions cleanrl/ppo_atari_envpool_xla_jax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,24 +210,6 @@ class EpisodeStatistics:
returned_episode_lengths=jnp.zeros(args.num_envs, dtype=jnp.int32),
)
handle, recv, send, step_env = envs.xla()

def step_env_wrappeed(episode_stats, handle, action):
handle, (next_obs, reward, next_done, info) = step_env(handle, action)
new_episode_return = episode_stats.episode_returns + info["reward"]
new_episode_length = episode_stats.episode_lengths + 1
episode_stats = episode_stats.replace(
episode_returns=(new_episode_return) * (1 - info["terminated"]) * (1 - info["TimeLimit.truncated"]),
episode_lengths=(new_episode_length) * (1 - info["terminated"]) * (1 - info["TimeLimit.truncated"]),
# only update the `returned_episode_returns` if the episode is done
returned_episode_returns=jnp.where(
info["terminated"] + info["TimeLimit.truncated"], new_episode_return, episode_stats.returned_episode_returns
),
returned_episode_lengths=jnp.where(
info["terminated"] + info["TimeLimit.truncated"], new_episode_length, episode_stats.returned_episode_lengths
),
)
return episode_stats, handle, (next_obs, reward, next_done, info)

assert isinstance(envs.single_action_space, gym.spaces.Discrete), "only discrete action space is supported"

def linear_schedule(count):
Expand Down Expand Up @@ -405,7 +387,26 @@ def rollout(agent_state, episode_stats, next_obs, next_done, storage, key, handl
storage, action, key = get_action_and_value(agent_state, next_obs, next_done, storage, step, key)

# TRY NOT TO MODIFY: execute the game and log data.
episode_stats, handle, (next_obs, reward, next_done, _) = step_env_wrappeed(episode_stats, handle, action)
handle, (next_obs, reward, next_done, info) = step_env(handle, action)

# record episodic statistics
new_episode_return = episode_stats.episode_returns + info["reward"]
new_episode_length = episode_stats.episode_lengths + 1
episode_stats = episode_stats.replace(
episode_returns=(new_episode_return) * (1 - info["terminated"]) * (1 - info["TimeLimit.truncated"]),
episode_lengths=(new_episode_length) * (1 - info["terminated"]) * (1 - info["TimeLimit.truncated"]),
# only update the `returned_episode_returns` if the episode is done
returned_episode_returns=jnp.where(
info["terminated"] + info["TimeLimit.truncated"],
new_episode_return,
episode_stats.returned_episode_returns,
),
returned_episode_lengths=jnp.where(
info["terminated"] + info["TimeLimit.truncated"],
new_episode_length,
episode_stats.returned_episode_lengths,
),
)
storage = storage.replace(rewards=storage.rewards.at[step].set(reward))
return agent_state, episode_stats, next_obs, next_done, storage, key, handle, global_step

Expand Down
Loading