Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is SAC exploration-noise used? #361

Closed
StoneT2000 opened this issue Mar 7, 2023 · 1 comment · Fixed by #362
Closed

Is SAC exploration-noise used? #361

StoneT2000 opened this issue Mar 7, 2023 · 1 comment · Fixed by #362

Comments

@StoneT2000
Copy link

Was looking at the SAC continuous action implementation and I noticed theres an used exploration-noise parameter. Is this used anywhere (or by any other libs?)

https://github.com/vwxyzjn/cleanrl/blob/master/cleanrl/sac_continuous_action.py#L52

Currently trying to compare my own code with OpenRL Benchmark results so was trying to align the hyperparameters.

@vwxyzjn
Copy link
Owner

vwxyzjn commented Mar 9, 2023

Ah this is probably just copied and pasted from the ddpg base implementation. Let me make a PR to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants