Skip to content
This repository was archived by the owner on Jan 14, 2020. It is now read-only.

whereis lookup logic is wrong #4

Closed
techtonik opened this issue May 2, 2015 · 3 comments
Closed

whereis lookup logic is wrong #4

techtonik opened this issue May 2, 2015 · 3 comments

Comments

@techtonik
Copy link

The package should not fallback on whereis if which failed on Linux. See webdriverio/selenium-standalone#96 for the example of mislocating java binary by trusting whereis.

See https://superuser.com/questions/40301/which-whereis-differences for the explanation of whereis command. It should come with additional checks to get binaries correctly.

@vvo
Copy link
Owner

vvo commented May 24, 2015

I am happy to take a PR on this @techtonik

@techtonik
Copy link
Author

Not sure it will happen any time soon. As I don't code in JavaScript, there is bigger issue with understanding the whole Gratipay JS testing toolchai, and it will just take more time for me than for somebody who knows how npm works and deal with it daily.

@vvo
Copy link
Owner

vvo commented May 25, 2015

@techtonik I think using https://github.com/isaacs/node-which is the way to go

@vvo vvo closed this as completed May 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants