Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan for supporting AWS OpenSearch #308

Open
ben-charles opened this issue Apr 21, 2021 · 5 comments
Open

Plan for supporting AWS OpenSearch #308

ben-charles opened this issue Apr 21, 2021 · 5 comments

Comments

@ben-charles
Copy link

How compatible will this plugin be with future versions of Elasticsearch and AWS OpenSearch? Will they both be supported?

@lukas-vlcek
Copy link
Collaborator

lukas-vlcek commented Apr 21, 2021

IMO this plugin is fully community driven. Does this answer the question?
In other words, if there will be enough hands to help with support one or the other stack then I do not see why both can't be supported.

@ben-charles
Copy link
Author

That makes sense to me. I was mainly wondering if there was an official stance on this or not, since we will likely need separate releases for Elasticsearch/OpenSearch in the future.

@lukas-vlcek
Copy link
Collaborator

It is really hard to say what the future holds here...

I can imagine it may become impossible to support both options if the code diverse. And it is not only about the compatibility of ES vs OS itself. It is also about relevant tooling, for instance this plugin rely on gradle esplugin (for integration tests, for building and plugin manifest automation, ... etc). IMO all 3rd party ES plugins will face this challenge sooner or later.

In the end the code of this plugin is not that complex and it may be easier to start parallel project for AWS OS if supporting both options in one code base is not practical.

@lukas-vlcek
Copy link
Collaborator

BTW, as for OpenSearch there is relevant discussion about plugin development and release versioning and cadence: opensearch-project/OpenSearch#95

@rursprung
Copy link

In the end the code of this plugin is not that complex and it may be easier to start parallel project for AWS OS if supporting both options in one code base is not practical.

turns out that this is what has happened, there's now a fork by @aparo of your plugin to support OpenSearch: https://github.com/aparo/opensearch-prometheus-exporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants