Fsync doesn't work

[psychaos999]

Hi,
I have tried with latest releases of proton-ge and lutris-wine and there is no way to enable fsync (WINEFSYNC=1 and all)
Esync works

[vulturm]

Hi,
Oh. That is interesting.

I see from the compile logs that the patches were applied during the build phase: https://download.copr.fedorainfracloud.org/results/xxmitsu/kernel-fedora-fsync/fedora-31-x86_64/01337710-kernel/builder-live.log.gz

Applying: futex: Split key setup from key queue locking and read
Applying: futex: Implement mechanism to wait on any of several futexes

I'll search to see if there are updated patches. Thanks for notification.

[vulturm]

Hey,
it seems that upstream has changed the way they apply patches in this spec. Could you please test the latest build?

[psychaos999]

Hi vulturm,
This time fsync works.

But as an aside, may I ask to configure your kernels with
#CONFIG_DEBUG_SPINLOCK is not set

and not
CONFIG_DEBUG_SPINLOCK=y
It seems to me you are using fedora debug kernel and the suffers from a great loss of performance, de facto making useless to test them (at least performance wise)

[vulturm]

Oh, I see. Thanks for noticing.

That's because it basically inherits everything from https://src.fedoraproject.org/rpms/kernel.git , which is the default distro kernel development for fedora.
On top of that is just adding the fsync patches.

The idea was to have bleeding edge kernel code, with fsync on top.

I'll look into how could I automate the generation of the new spec with the features that are hurting the performance disabled.

[psychaos999]

From kernel-5.7.0-0.rc5.1 at least I dont see any problem performance wise.
I suppose u can close this issue

[vulturm]

Sorry, I couldn't find time to look into this.

One explanations might be the fact that during lower RC kernels fedora enables debug symbols and such to be able to find defects early on. And those might impact performance.

Because this repo follows upstream repo, it also inherits those.
So I suppose this will happen again when when 5.8 RC0 ... and such.