From 4eb92d1eed442470417785b52a7560bbfafc7d43 Mon Sep 17 00:00:00 2001 From: Michael Riley Date: Tue, 2 Apr 2024 08:33:33 -0400 Subject: [PATCH 1/2] Set correct flag type on LB proxy protocol --- cmd/loadbalancer/loadbalancer.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/loadbalancer/loadbalancer.go b/cmd/loadbalancer/loadbalancer.go index 91da4295..3c6af0aa 100644 --- a/cmd/loadbalancer/loadbalancer.go +++ b/cmd/loadbalancer/loadbalancer.go @@ -337,7 +337,7 @@ func NewCmdLoadBalancer(base *cli.Base) *cobra.Command { //nolint:funlen,gocyclo `(optional) if true, this will redirect HTTP traffic to HTTPS. You must have an HTTPS rule and SSL certificate installed on the load balancer to enable this option.`, ) - create.Flags().StringP("proxy-protocol", "p", "", "(optional) if true, you must configure backend nodes to accept Proxy protocol.") + create.Flags().BoolP("proxy-protocol", "p", false, "(optional) if true, you must configure backend nodes to accept Proxy protocol.") create.Flags().StringArrayP( "forwarding-rules", "f", From bfe1b728f651e5429fb64a3dccf57deca109ab3f Mon Sep 17 00:00:00 2001 From: Michael Riley Date: Tue, 2 Apr 2024 08:51:27 -0400 Subject: [PATCH 2/2] Fix flag proxy protocol on LB update as well --- cmd/loadbalancer/loadbalancer.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/loadbalancer/loadbalancer.go b/cmd/loadbalancer/loadbalancer.go index 3c6af0aa..635983cd 100644 --- a/cmd/loadbalancer/loadbalancer.go +++ b/cmd/loadbalancer/loadbalancer.go @@ -625,7 +625,7 @@ func NewCmdLoadBalancer(base *cli.Base) *cobra.Command { //nolint:funlen,gocyclo `(optional) if true, this will redirect HTTP traffic to HTTPS. You must have an HTTPS rule and SSL certificate installed on the load balancer to enable this option.`, ) - update.Flags().StringP("proxy-protocol", "p", "", "(optional) if true, you must configure backend nodes to accept Proxy protocol.") + update.Flags().BoolP("proxy-protocol", "p", false, "(optional) if true, you must configure backend nodes to accept Proxy protocol.") update.Flags().StringArrayP( "forwarding-rules", "f",