Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Two options which could probably be boolean instead of enum #480

Open
zikalino opened this issue Oct 17, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@zikalino
Copy link
Contributor

zikalino commented Oct 17, 2024

Describe the bug

There are two options in baremetal defined as enums:

create.Flags().StringP(
	"ipv6",
	"i",
	"",
	"(optional) Whether IPv6 is enabled on the server. Possible values: 'yes', 'no'. Defaults to 'no'.",
)

and

create.Flags().StringP(
	"notify",
	"n",
	"",
	`(optional) Whether an activation email will be sent when the server is ready. Possible values: 'yes', 'no'. 

Defaults to 'yes'.`,
)

I wonder why they are not defined as BoolP options. Is it intentional?

Since second option default value is yes, it would probably make sense to have --suppress-notification so users.
Also I wonder what is breaking changes policy for vultr-cli?

If it makes sense, i could create a PR.

@zikalino zikalino added the bug Something isn't working label Oct 17, 2024
@zikalino zikalino changed the title [BUG] Two options which could probably be boolean instead of enum [Feature] Two options which could probably be boolean instead of enum Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant