fix(VDialog): remove console error on escape keypress (#7030)

* fix(VDialog): pass event parameter * test(VDialog): add test on escape keydown * fix(VDialog): remove consoleError
vuetifyjs · Apr 22, 2019 · f2303f1 · f2303f1
1 parent 415f8ca
commit f2303f1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/packages/vuetify/src/components/VDialog/VDialog.js b/packages/vuetify/src/components/VDialog/VDialog.js
@@ -234,7 +234,7 @@ export default {
         if (el) return el
       }
 
-      consoleError('No activator found')
+      return null
     },
     genActivator () {
       if (!this.hasActivator) return null

diff --git a/packages/vuetify/test/unit/components/VDialog/VDialog.spec.js b/packages/vuetify/test/unit/components/VDialog/VDialog.spec.js
@@ -1,5 +1,6 @@
 import VDialog from '@/components/VDialog'
 import { test } from '@/test'
+import { keyCodes } from '@/util/helpers'
 import Vue from 'vue'
 
 test('VDialog.js', ({ mount, compileToFunctions }) => {
@@ -252,4 +253,17 @@ test('VDialog.js', ({ mount, compileToFunctions }) => {
 
     expect('Unable to locate target [data-app]').toHaveBeenTipped()
   })
+
+  it('should close dialog on escape keydown', () => {
+    const wrapper = mount(VDialog, {
+      propsData: { value: true }
+    })
+
+    const escape = new Event('keydown')
+    escape.keyCode = keyCodes.esc
+    wrapper.vm.$refs.content.dispatchEvent(escape)
+    expect(wrapper.vm.isActive).toBe(false)
+
+    expect('Unable to locate target [data-app]').toHaveBeenTipped()
+  })
 })