Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lazy-loading for products data #3706

Closed
pkarw opened this issue Oct 10, 2019 · 0 comments
Closed

Implement lazy-loading for products data #3706

pkarw opened this issue Oct 10, 2019 · 0 comments
Assignees
Labels
5: Complex feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P3: Normal Priority mark - normal priority
Milestone

Comments

@pkarw
Copy link
Collaborator

pkarw commented Oct 10, 2019

What is the motivation for adding / enhancing this feature?

Currently, when user enters product page or category we're downloading pretty heavy data file including all product infromation - category-next/storeproduct/actions:cacheProducts is being called. In CSR it's even 2 requests - first is for simplified JSON file; second is executed just to cache all the products in browser memory and the feed in the Service Worker

This sucks on slow 3g connections.

We should have a configurable data fetching strategy to save the bandwidth. We should keep VSF as it is and have config.api.saveBandwidthOverCache=false default option. If it's true - then we shouldn't cache products and categories but rather limit the set of fields being used for getting the data; launching network call each time user is entering product page to get just this product info (probably we can also limit the number of fields being retrieved a little bit)

This is kind of R&D task

@pkarw pkarw added feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P3: Normal Priority mark - normal priority 5: Complex labels Oct 10, 2019
@andrzejewsky andrzejewsky self-assigned this Oct 17, 2019
@pkarw pkarw added this to the 1.12.0-rc1 milestone Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5: Complex feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P3: Normal Priority mark - normal priority
Projects
None yet
Development

No branches or pull requests

2 participants