Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MdTabs): correct indicator position on transition end #1467

Merged
merged 1 commit into from
Feb 2, 2018
Merged

fix(MdTabs): correct indicator position on transition end #1467

merged 1 commit into from
Feb 2, 2018

Conversation

VdustR
Copy link
Member

@VdustR VdustR commented Feb 2, 2018

I tested the case #1432 (comment) I got min-width as the last property on transition end, so I setIndicatorStyles while that transition end.

if (event.propertyName !== 'min-width') {

In this case #1432 (comment), I got flex-grow as the last transition end.

We never know which property is the last transition end, so I think it's better to setIndicatorStyles on every transitionend.

I tried to use transitionstart to implement a counter for checking which property is on the last transition end, but that is an experimental technology.

relate to #1442

fix #1432

@marcosmoura marcosmoura merged commit bc3b611 into vuematerial:dev Feb 2, 2018
@VdustR VdustR deleted the fix#1432comment-362102707 branch February 2, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MdTab] underline misplaced when "fixed" alignment is changed after initial render
2 participants