fix: add updated hook (#675)

closes #661
vuejs · Jun 1, 2018 · 9a2a25a · 9a2a25a
1 parent 0ab5a75
commit 9a2a25a
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 1 deletion.
diff --git a/packages/test-utils/src/set-watchers-to-sync.js b/packages/test-utils/src/set-watchers-to-sync.js
@@ -1,3 +1,5 @@
+import { VUE_VERSION } from './consts'
+
 function setDepsSync (dep) {
   dep.subs.forEach(setWatcherSync)
 }
@@ -24,4 +26,16 @@ export function setWatchersToSync (vm) {
   setWatcherSync(vm._watcher)
 
   vm.$children.forEach(setWatchersToSync)
+  // preventing double registration
+  if (!vm.$_vueTestUtils_updateInSetWatcherSync) {
+    vm.$_vueTestUtils_updateInSetWatcherSync = vm._update
+    vm._update = function (vnode, hydrating) {
+      this.$_vueTestUtils_updateInSetWatcherSync(vnode, hydrating)
+      if (VUE_VERSION >= 2.1 && this._isMounted && this.$options.updated) {
+        this.$options.updated.forEach((handler) => {
+          handler.call(this)
+        })
+      }
+    }
+  }
 }
diff --git a/test/specs/mounting-options/sync.spec.js b/test/specs/mounting-options/sync.spec.js
@@ -1,3 +1,4 @@
+import sinon from 'sinon'
 import { describeWithShallowAndMount } from '~resources/utils'
 
 describeWithShallowAndMount('options.sync', (mountingMethod) => {
@@ -46,7 +47,7 @@ describeWithShallowAndMount('options.sync', (mountingMethod) => {
             <pre>computed.text: <em>{{ computedText }}</em></pre>
           </div>
         </div>
-        </div>
+      </div>
       `,
       data () {
         return {
@@ -110,4 +111,38 @@ describeWithShallowAndMount('options.sync', (mountingMethod) => {
       done()
     })
   })
+
+  it('call updated when sync is not false', () => {
+    const childComponentSpy = sinon.stub()
+    const ChildComponent = {
+      template: '<div>{{ foo }}</div>',
+      props: ['foo'],
+      updated () {
+        childComponentSpy()
+      }
+    }
+    const spy = sinon.stub()
+    const TestComponent = {
+      template: '<div>{{ foo }}<child-component :foo="foo" /></div>',
+      data () {
+        return {
+          foo: 'foo'
+        }
+      },
+      updated () {
+        spy()
+      }
+    }
+    const wrapper = mountingMethod(TestComponent, {
+      stubs: { 'child-component': ChildComponent },
+      sync: true
+    })
+    expect(spy.notCalled).to.equal(true)
+    expect(childComponentSpy.notCalled).to.equal(true)
+    expect(wrapper.html()).to.equal('<div>foo<div>foo</div></div>')
+    wrapper.vm.foo = 'bar'
+    expect(spy.calledOnce).to.equal(true)
+    expect(childComponentSpy.calledOnce).to.equal(true)
+    expect(wrapper.html()).to.equal('<div>bar<div>bar</div></div>')
+  })
 })