-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Implement Scoped Slot string support #115
Conversation
I played with this, seems good. I wonder if we need any tests with PS: I fixed the build. We had to specify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks @znck and @dobromir-hristov.
OK yeah awesome. As I said I did not have time to spend on it, but glad you figured it out :))) I think we should make note in the docs that it needs to be present. Jessica's Vite toy project would need it. Overall I am very very happy with how this turned out. It reduced the complexity by N times, everything is handled by the Vue compiler. Sure we have a hacky string to function thing, but thats fine 😆 I can add more tests if anyone thinks of something? Maybe some not so happy paths? |
I have updated the rollup config further here: https://github.com/vuejs/vue-test-utils-next/pulls We have it listed as a peer dependency, I think this should be okay. For Vite, it will work out of the box, since all the packages in vue-next have the Sure, feel free to add more tests - would be happy to merge as is, as well. I'll leave this decision up to you since you own this feature 👍 |
We can't avoid string to function conversion, even full build of Vue uses the same thing: |
This PR implements the previously very convenient scoped slot syntax of providing just a template string.