New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if router query have null or undefined value, will throw error #1725

Closed

svkd9 opened this issue Sep 8, 2017 · 1 comment

svkd9 commented Sep 8, 2017

Version

2.7.0

Reproduction link

https://github.com/vuejs/vue-router/blob/v2.7.0/src/util/route.js#L86

Steps to reproduce

const routerQuery = {
a: null,
b: undefined
}
this.$router.push({name: 'routerName', query: routerQuery})

What is expected?

no error

What is actually happening?

throw error 'Cannot convert undefined or null to object'

i think the problem maybe in https://github.com/vuejs/vue-router/blob/v2.7.0/src/util/route.js#L86

typeof aVal === 'object' ====> Object.prototype.toString.call(aVal) === '[object Object]'

Member

posva commented Sep 8, 2017

Dup of some other issue, PR to fix this at #1568

posva closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment