Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title mixin should use provide() for Vue 2.4.x #230

Open
aeharding opened this issue Jul 27, 2017 · 1 comment
Open

Title mixin should use provide() for Vue 2.4.x #230

aeharding opened this issue Jul 27, 2017 · 1 comment

Comments

@aeharding
Copy link

aeharding commented Jul 27, 2017

I used the title mixin in my app with SSR and upgrading to 2.4.0 lead to the dreaded mergeData stack overflow exception.

Wrapping the static delaration in a provide() function fixes it.

https://github.com/vuejs/vue-hackernews-2.0/blob/master/src/util/title.js

vuejs/vue#6190

@aeharding aeharding changed the title Title mixin should use provide() Title mixin should use provide() for Vue 2.4.x Jul 27, 2017
@aeharding
Copy link
Author

Well, after some investigation, I can't get this to work when wrapping with provide(). I guess I don't understand mixins well enough. I also can't seem to duplicate the stack overflow with this project, but I can with mine (using the exact same mixin). Removing the title mixin from my project makes the error disappear as well.

Any advice is appreciated. For now, I guess I'm stuck on 2.3.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant