Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge file config and inline options #5644

Open
myin142 opened this issue Jul 3, 2020 · 0 comments
Open

Merge file config and inline options #5644

myin142 opened this issue Jul 3, 2020 · 0 comments

Comments

@myin142
Copy link

myin142 commented Jul 3, 2020

What problem does this feature solve?

Currently if you have inline options set in the Service and a vue config file, then inline options will be completely ignored. That is inconvenient if you want to programmatically set options but also allow the user to override these.

For example the NX Plugin for Vue.
They are setting inline options programmatically when building the application. But if I for example want to set the publicPath using a vue config file, then the normal build options are not used anymore.

What does the proposed API look like?

Is it not possible to just extend the inline options in the Service.js file? I have not looked at other classes but I do not see an usage for inline options if it is completely ignored if any other config exists.

resolved = {
    ...(this.inlineOptions || {}),
    ...resolved,
};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant