Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line break before "external link icon" #1864

Closed
3 tasks done
sbleh opened this issue Jan 30, 2023 · 3 comments · Fixed by #1880
Closed
3 tasks done

Fix line break before "external link icon" #1864

sbleh opened this issue Jan 30, 2023 · 3 comments · Fixed by #1880
Labels
theme Related to the theme

Comments

@sbleh
Copy link

sbleh commented Jan 30, 2023

Describe the bug

Since 1.0.0-alpha.41, there is a line break before the external link icon (arrow right up) for links going to other websites.

Reproduction

.

Expected behavior

Having it inline with the title of that link.

System Info

.

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@sbleh sbleh added the bug: pending triage Maybe a bug, waiting for confirmation label Jan 30, 2023
@brc-dd brc-dd added bug theme Related to the theme and removed bug: pending triage Maybe a bug, waiting for confirmation labels Jan 30, 2023
@brc-dd
Copy link
Member

brc-dd commented Jan 30, 2023

hey, is it broken anywhere except the sidebar?

@sbleh
Copy link
Author

sbleh commented Jan 30, 2023

Haven't found anything else. It's not really broken but unexpected formatting.

@brc-dd
Copy link
Member

brc-dd commented Feb 1, 2023

/cc @kiaking We currently have

<VPLink :tag="linkTag" class="link" :href="item.link">
<component :is="textTag" class="text" v-html="item.text" />
</VPLink>

I don't think we can move svg inside the text tag. We however can have something like this using flex (external link icons are right aligned):

image

Created #1880, have a look. Any better solution where we can have it like it was earlier (just after the text end)?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme Related to the theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants