-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Write components that are easy to test" #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Various comments, mostly just food for thought - happy to let you own this one and do what like with it!
src/guide/write-easy-test.md
Outdated
|
||
## Build smaller components | ||
|
||
If a component does less, then it will be easier to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an interesting one. sometimes this can go too far, and people write tiny components and unit test those, which is kind of like testing an implementation detail (not really, but you can imagine if someone had 10 components for a form, and tested each one individually, that would not be as useful as 1 test on the form itself).
this is just my opinion though - I don't have a test file for every component, but I try to have tests that cover all of the components (indirectly is fine, like a form). not sure how opinionated we should be here, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rephrased it to make it read as a suggestion:
"A general rule of thumb is that if a component does less, then it will be easier to test."
Check out the [Making HTTP requests](../guide/http-requests.md) guide if you are unfamiliar with testing API calls. | ||
::: | ||
|
||
Usually, you will perform several HTTP requests throughout your application. From a testing perspective, HTTP requests provide inputs to the component, and a component can also send HTTP requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, i love this
a544c6c
to
6b4837b
Compare
Closes #34