-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): unwrap refs in mapWritableState
for setup stores
#2805
Conversation
✅ Deploy Preview for pinia-official canceled.
|
✅ Deploy Preview for pinia-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #2805 +/- ##
=======================================
Coverage 88.39% 88.39%
=======================================
Files 19 19
Lines 1439 1439
Branches 227 227
=======================================
Hits 1272 1272
Misses 166 166
Partials 1 1 ☔ View full report in Codecov by Sentry. |
@posva When is this PR scheduled to be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I wanted to remove the redundancy with SS
so I used UnwrapRef
like Store
does to correctly extract the final type.
close #2804