Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reference the store directly in storeToRefs to ensure correct reactivity after HMR #2795

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

babu-ch
Copy link
Contributor

@babu-ch babu-ch commented Oct 8, 2024

fix: #2779

I have a store referenced with toRaw, so it doesn’t update when it changes.
By referencing a store that is not wrapped in toRaw, it updates as expected.
If it is necessary to reference something wrapped in toRaw, I apologize.

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit 896aa24
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/6705422dc302290007007bb2

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for pinia-playground ready!

Name Link
🔨 Latest commit 896aa24
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/6705422da5187b0009e690d8
😎 Deploy Preview https://deploy-preview-2795--pinia-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 8, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@pinia/nuxt@2795
pnpm add https://pkg.pr.new/pinia@2795
pnpm add https://pkg.pr.new/@pinia/testing@2795

commit: 896aa24

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.71%. Comparing base (ecc7449) to head (896aa24).
Report is 10 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #2795      +/-   ##
==========================================
+ Coverage   90.11%   90.71%   +0.59%     
==========================================
  Files          14       14              
  Lines        1335     1335              
  Branches      220      221       +1     
==========================================
+ Hits         1203     1211       +8     
+ Misses        131      123       -8     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit 254eec7 into vuejs:v2 Oct 17, 2024
8 checks passed
@babu-ch babu-ch deleted the fix/2779_ branch October 17, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

define var storeToRefs(store) HMR not work as expected
2 participants