Fix issues with props #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* prop-name-casing: is working now with array props [literals] * prop-name-casing: reports all errors if there are non Literal keys in it * require-prop-types: reports names for types diffrent than literals * add new getPropsProperties helper to easly deal with props
* fix issue vuejs#596 * allow to use shorthand
fix issue vuejs#595
michalsnik
reviewed
Nov 7, 2018
|
@michalsnik all requested changes are applied, |
armano2
added a commit
to armano2/eslint-plugin-vue
that referenced
this pull request
Nov 7, 2018
* rename `getPropsProperties` to `getComponentProps` … * fix false error in `require-prop-types` when is set to empty array * `require-prop-types` will return now errors about each prop from ArrayExpression * add more tests
michalsnik
suggested changes
Nov 10, 2018
|
@michalsnik requested changes applied |
michalsnik
approved these changes
Nov 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With those changes, its going to be easier to add support for classes in feature
vue/prop-name-casing: is working now with array props [literals]vue/prop-name-casing: reports all errors if there are non Literal keys in itvue/require-default-prop: allow to use shorthand, properties and function callsvue/require-prop-types: reports names for types different than literalsvue/require-prop-types: fix false positive error in when is set to empty arrayvue/require-prop-types: will return now errors about each prop from ArrayExpressiongetComponentPropshelper to easily deal with propsproprelated rulesfix issue: #596
fix issue #595