-
-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding a policy about not supporting Nuxt. (In conclusion, we will continue to support Nuxt.) #2058
Comments
@FloEdelmann I would love to hear your opinion. Could you please comment when you have time? |
I will be watching with interest. I am very happy to support (e.g. maintain/contribute as you would value) this plugin from the Nuxt side if you would like to consolidate effort, where possible. |
Thank you for your comment. Whether this plugin supports Nuxt or leaves it to eslint-plugin-nuxt, we need help from the Nuxt team 😃 |
For me personally since I use options API, just making it support |
Yeah, but supporting it in the same way as defineComponent is a breaking change. I'm not sure if the major version of this plugin should be bumped for Nuxt at the moment. |
My current idea for defineNuxtComponent is to provide a way to specify the Vue options object from eslint-plugin-vue in settings etc. and use it from eslint-plugin-nuxt to extend it for Nuxt. |
That makes a lot of sense, and allow to use multiple options, to use |
Why would treating My opinion on the whole topic: I think we should try to support Nuxt features that are working similarly to Vue core features. IMO, that includes both #2057 and #1969. We could introduce a per-rule or shared settings that should be considered "Vue". E.g.: {
"settings": {
"vuePackageNames": ["vue", "@vue/composition-api", "#imports"]
}
} So importing |
Thank you for your comment!
I think it's a breaking change at the core of this plugin. I think it will generate quite a lot of errors and users will have to do a lot of migration work. Do you think I worry too much?
Thank you for your opinion. So let us try to make eslint-plugin-vue support Nuxt3 features.
I still can't decide if that makes sense. Because I still don't understand which APIs auto-import can auto import and which ones it can't 😓. If you know the location of the documentation that lists APIs that can be auto-imported, please let me know. |
Maybe we should clarify in the docs that a new minor (or even patch) version of eslint-plugin-vue could result in more reported lint issues. And that this is the case especially for users of Nuxt and other third-party frameworks built on top of Vue. |
All my Vue projects are actually based on Nuxt, and not supporting Nuxt for me will make this plugin basically pointless. |
I think we have been trying to support Nuxt as much as possible, but nuxt3 adds many unique features, so it seems that it is almost incompatible with eslint-plugin-vue.
Nuxt support should be left to eslint-plugin-nuxt and eslint-plugin-vue should consider whether it should focus on supporting vue core features.
https://github.com/nuxt/eslint-plugin-nuxt
The text was updated successfully, but these errors were encountered: