-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings tab #547
Comments
I would leave recording toggles in their respective tabs, because it also displays the information that recording is activated or not. |
@Akryum I think he refers to the starting state, without affecting existing toggles. |
Well, it's not the same? We already save the starting state. |
The use case may be:
|
So you mean a global default setting, and a per-app setting with toggled? |
Not necessarily, although that would be better I think because you might close the devtools in the middle of debugging, but initially I thought that if you close the devtools and reopen them, they should go back to the state specified in the settings |
That would make it worse than currently, because you will need to turn recording on each time you open the devtools. |
but I think that's what some people want because they regularly use a heave event-based app |
My comment was about:
|
What if we also provide a way to configure the devtools in the user app code? |
it could also work |
I don't think it would be a preferable way of configuring devtools, it's configuration should be separated from the app. I also find it more natural to have a dedicated place where I can set all my preferences regarding devtools, and expect they won't change when I change project. Only I use my devtools so I have no interest in having different settings per project regarding them :) Though I might have different preferences regarding current machine I'm working on (I'm speaking about high density mode), on 13" macbook I might prefer it, but on 34" desktop not really, so being able to save those setting in local storage or somewhere we can keep it from disappearing has a lot of sense to me :) So it's a +1 from my side 👍 But we need to separate temporary settings from global ones. Recording seems like a temporary setting to me. If you want it to be enabled by default though you could set in settings, if not - leave temporary, and you'll have to toggle it yourself when needed :) |
Ok so to pitch in, in that settings tab, there should be an 'Appearance' one. Copied from issue #570:
|
I think we can have 3 sections:
Each section could have multiple tabs |
I really like the idea of per-site override! I could boost productivity immensely. I'll happily help out |
First iteration: 14e05a2 |
We may evolve this in the future but I think current implementation is good enough for now. |
I'd like to open a discussion regarding
Settings
tab as mentioned in #543I think it is high time to add
Settings
tab to devtools. Some of the things that could live there:Devtools are under fast development these days, more and more options pop up. It causes cluttering of each respective tab. Creating separate tab for all customizable settings might be a good idea to make it easier to tweak devtools to your preference.
I'm happy to implement it once we settle on what goes to that tab.
The text was updated successfully, but these errors were encountered: